From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Paul Holzinger <pholzing@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/23] Allow configuration of special case NATs
Date: Wed, 21 Aug 2024 14:19:56 +1000 [thread overview]
Message-ID: <20240821042020.718422-1-david@gibson.dropbear.id.au> (raw)
Based on Stefano's recent patch for faster tests.
Allow the user to specify which addresses are translated when used by
the guest, rather than always being the gateway address or nothing.
We also allow this remapping to go to the host's global address (more
precisely the address assigned to the guest) rather than just host
loopback.
Along the way to implementing that make many changes to clarify what
various addresses we track mean, fixing a number of small bugs as
well.
Paul, amongst other things, I think this will allow podman to
(finally) nicely address #19213, picking an address to remap to the
host's external address with --map-guest-addr, much like it already
uses --dns-forward.
Changes in v2:
* Assorted minor stylistic fixes based on Stefano's review
* Change name of the new options from --nat-* to --map-*
* Shorten descriptions of new options in --help (leave the full text
to the man page)
* Add fix for the fact that changing MTU causes IPv6 to be
temporarily deconfigured during perf tests
David Gibson (23):
treewide: Use "our address" instead of "forwarding address"
util: Helper for formatting MAC addresses
treewide: Rename MAC address fields for clarity
treewide: Use struct assignment instead of memcpy() for IP addresses
conf: Use array indices rather than pointers for DNS array slots
conf: More accurately count entries added in get_dns()
conf: Move DNS array bounds checks into add_dns[46]
conf: Move adding of a nameserver from resolv.conf into subfunction
conf: Correct setting of dns_match address in add_dns6()
conf: Treat --dns addresses as guest visible addresses
conf: Remove incorrect initialisation of addr_ll_seen
util: Correct sock_l4() binding for link local addresses
treewide: Change misleading 'addr_ll' name
Clarify which addresses in ip[46]_ctx are meaningful where
Initialise our_tap_ll to ip6.gw when suitable
fwd: Helpers to clarify what host addresses aren't guest accessible
fwd: Split notion of "our tap address" from gateway for IPv4
Don't take "our" MAC address from the host
conf, fwd: Split notion of gateway/router from guest-visible host
address
test: Reconfigure IPv6 address after changing MTU
conf: Allow address remapped to host to be configured
fwd: Distinguish translatable from untranslatable addresses on inbound
fwd, conf: Allow NAT of the guest's assigned address
arp.c | 4 +-
conf.c | 318 +++++++++++++++++++++++++-----------------
dhcp.c | 21 +--
dhcpv6.c | 21 +--
flow.c | 72 +++++-----
flow.h | 18 +--
fwd.c | 170 +++++++++++++++++-----
icmp.c | 4 +-
ndp.c | 9 +-
passt.1 | 43 +++++-
passt.c | 2 +-
passt.h | 53 +++++--
pasta.c | 14 +-
tap.c | 12 +-
tcp.c | 33 ++---
tcp_internal.h | 2 +-
test/lib/setup | 11 +-
test/passt_in_ns/dhcp | 73 ++++++++++
test/passt_in_ns/tcp | 38 +++--
test/passt_in_ns/udp | 22 +--
test/perf/passt_tcp | 37 ++---
test/perf/passt_udp | 31 ++--
test/perf/pasta_tcp | 29 ++--
test/perf/pasta_udp | 25 ++--
test/run | 4 +-
udp.c | 12 +-
util.c | 22 ++-
util.h | 4 +-
28 files changed, 712 insertions(+), 392 deletions(-)
create mode 100644 test/passt_in_ns/dhcp
--
2.46.0
next reply other threads:[~2024-08-21 4:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 4:19 David Gibson [this message]
2024-08-21 4:19 ` [PATCH v2 01/23] treewide: Use "our address" instead of "forwarding address" David Gibson
2024-08-21 4:19 ` [PATCH v2 02/23] util: Helper for formatting MAC addresses David Gibson
2024-08-21 4:19 ` [PATCH v2 03/23] treewide: Rename MAC address fields for clarity David Gibson
2024-08-21 4:20 ` [PATCH v2 04/23] treewide: Use struct assignment instead of memcpy() for IP addresses David Gibson
2024-08-21 4:20 ` [PATCH v2 05/23] conf: Use array indices rather than pointers for DNS array slots David Gibson
2024-08-21 4:20 ` [PATCH v2 06/23] conf: More accurately count entries added in get_dns() David Gibson
2024-08-21 4:20 ` [PATCH v2 07/23] conf: Move DNS array bounds checks into add_dns[46] David Gibson
2024-08-21 4:20 ` [PATCH v2 08/23] conf: Move adding of a nameserver from resolv.conf into subfunction David Gibson
2024-08-21 4:20 ` [PATCH v2 09/23] conf: Correct setting of dns_match address in add_dns6() David Gibson
2024-08-21 4:20 ` [PATCH v2 10/23] conf: Treat --dns addresses as guest visible addresses David Gibson
2024-08-21 4:20 ` [PATCH v2 11/23] conf: Remove incorrect initialisation of addr_ll_seen David Gibson
2024-08-21 4:20 ` [PATCH v2 12/23] util: Correct sock_l4() binding for link local addresses David Gibson
2024-08-21 4:20 ` [PATCH v2 13/23] treewide: Change misleading 'addr_ll' name David Gibson
2024-08-21 4:20 ` [PATCH v2 14/23] Clarify which addresses in ip[46]_ctx are meaningful where David Gibson
2024-08-21 4:20 ` [PATCH v2 15/23] Initialise our_tap_ll to ip6.gw when suitable David Gibson
2024-08-21 4:20 ` [PATCH v2 16/23] fwd: Helpers to clarify what host addresses aren't guest accessible David Gibson
2024-08-21 4:20 ` [PATCH v2 17/23] fwd: Split notion of "our tap address" from gateway for IPv4 David Gibson
2024-08-21 4:20 ` [PATCH v2 18/23] Don't take "our" MAC address from the host David Gibson
2024-08-21 4:20 ` [PATCH v2 19/23] conf, fwd: Split notion of gateway/router from guest-visible host address David Gibson
2024-08-21 4:20 ` [PATCH v2 20/23] test: Reconfigure IPv6 address after changing MTU David Gibson
2024-08-21 4:20 ` [PATCH v2 21/23] conf: Allow address remapped to host to be configured David Gibson
2024-08-21 4:20 ` [PATCH v2 22/23] fwd: Distinguish translatable from untranslatable addresses on inbound David Gibson
2024-08-21 4:20 ` [PATCH v2 23/23] fwd, conf: Allow NAT of the guest's assigned address David Gibson
2024-08-21 10:38 ` [PATCH v2 00/23] Allow configuration of special case NATs Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821042020.718422-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).