From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=LNRoUht0; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id B07CD5A0276 for ; Wed, 21 Aug 2024 06:20:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1724214023; bh=XaP96P+SpHuSIrUAV6Frn1vFy9yXhvpHCLUy+wQDOiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LNRoUht03tLYJ6qTT3LRxdWKxysFAYBPnjNqGaYqSzXl7QpYyW/xDFQ1utS1ARsMx fGE5YBbD3MP/YHtG6v9m7TEHVopmuqT8WDAr5/Dbnj6XEf8dyqhZ93+pIj5+rJpuOs /ma6FUqRJqBWhPbGK2+U8vyLmUGv9r9WWV/iWGkY5KCDhgjc04kIQJ8Y0EfDiHuv19 ltNXFBKAc4NfdB5p7EthoIY+nuZCUtCX3wsQ9YQeoysSs8EgbsLzf3zaXXw+fTVhNu WKHvp6dTYZ0ovJ07l68t5Bl9jQk/yyD2OGvkMejaCrK7erYwEYJtyBfE7EVHP1XLh+ xtjDg7KVJ+nLg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WpY5z2Jk4z4x8M; Wed, 21 Aug 2024 14:20:23 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 11/23] conf: Remove incorrect initialisation of addr_ll_seen Date: Wed, 21 Aug 2024 14:20:07 +1000 Message-ID: <20240821042020.718422-12-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240821042020.718422-1-david@gibson.dropbear.id.au> References: <20240821042020.718422-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: GG25RYSKZMV3TH5LA5SDVYO4F5RNCQ56 X-Message-ID-Hash: GG25RYSKZMV3TH5LA5SDVYO4F5RNCQ56 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Paul Holzinger , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Despite the names, addr_ll_seen does not relate to addr_ll the same way addr_seen relates to addr. addr_ll_seen is an observed address from the guest, whereas addr_ll is *our* link-local address for use on the tap link when we can't use an external endpoint address. It's used both for passt provided services (DHCPv6, NDP) and in some cases for connections from addresses the guest can't access. Signed-off-by: David Gibson --- conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/conf.c b/conf.c index 3c102bcf..e5b5263f 100644 --- a/conf.c +++ b/conf.c @@ -720,7 +720,6 @@ static unsigned int conf_ip6(unsigned int ifi, } ip6->addr_seen = ip6->addr; - ip6->addr_ll_seen = ip6->addr_ll; if (MAC_IS_ZERO(mac)) { rc = nl_link_get_mac(nl_sock, ifi, mac); -- 2.46.0