From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WqGXIx24; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 3892F5A026E for ; Mon, 26 Aug 2024 09:55:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724658954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjyiB8ZnFRxAfJFwNjTV3VaeXrX/NF6M7sqaZ1AZGZ0=; b=WqGXIx24Q/sHtJ3+R6aPF1iWUUvclKCmny4Exwarq1ixYsCOVZSDgp8ES6Ibnx9ay9BKXM 96isOMn3rXwwjTdhQsJ7E/+wfs5eY8QZ6z2YZUNmzKEJ8YDAU/kcCc0XYRVQj8cN4Txlkt D1CbfXeP4wLW6oD2pqq73wdNDMn9+ns= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-j43MW_haMF2UszX58s7hcg-1; Mon, 26 Aug 2024 03:55:52 -0400 X-MC-Unique: j43MW_haMF2UszX58s7hcg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-371b187634fso2355967f8f.0 for ; Mon, 26 Aug 2024 00:55:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724658951; x=1725263751; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yjyiB8ZnFRxAfJFwNjTV3VaeXrX/NF6M7sqaZ1AZGZ0=; b=b23lM9YFM2GT1fc+qLQ4HGqN0cHYZ3Gw2BuMIo91H+eOCPnGMSFFik/Ae0InbybYme Zfx6X7FuknQ5Q5uVuxLDAM2cidS0YtEtsz/74Sy/J0JhSPeGSgovY5NOUZX2WSKI4cna ctga+882HJSagxffwcqxPX99st4vMQ2hmwl461yHiANqio3oXmTPMVXqvVGhAE2lyE4j +tvSUrLQg/YiTv/mti0lAM7oe2+I30xSrxw/i5jGpU7Q80kfXDOg9jCuLgDtiDwtR6lW 2NyYlvQtpHKuCYgG7sG4ucr6OfmgOdzvnxaWoxD3m8cftK3R9uT30K7hi2Vlp2NoP469 2ezg== X-Gm-Message-State: AOJu0Yzbj2YUTbqA2KEmHDn9GxVrdkZaVmFmgEz1XO2HYCheE3gyO0Yb FMzoTkGb/gtww/8g95drwit1zVwd/BmiSzj4vbkmz9Zn/Y/0Lgf747ZdW9azX4+kOpzYqGUchBg x36hHRlR4gsbjND0i2V7QiD3e6udUbrUig5wJ3obyjmXxlv997alEvglSgw== X-Received: by 2002:a5d:4a8b:0:b0:362:2af4:43cc with SMTP id ffacd0b85a97d-37310ec7549mr4614631f8f.19.1724658950632; Mon, 26 Aug 2024 00:55:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8wH6MafOkOi5/QtQsigKgj/uDVngf2qc56WYgBDfCCh2lyRLFC4YTLkaGVECG6CZFPIylMA== X-Received: by 2002:a5d:4a8b:0:b0:362:2af4:43cc with SMTP id ffacd0b85a97d-37310ec7549mr4614614f8f.19.1724658949979; Mon, 26 Aug 2024 00:55:49 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730817a4bfsm10054035f8f.62.2024.08.26.00.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 00:55:48 -0700 (PDT) Date: Mon, 26 Aug 2024 09:55:47 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] Remove incorrect special handling of /usr/libexec Message-ID: <20240826095547.43a050fd@elisabeth> In-Reply-To: <20240826063901.590640-1-david@gibson.dropbear.id.au> References: <20240826063901.590640-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: DW4H3MEGWFBEY44HB47DP7Z5CTIY7MWA X-Message-ID-Hash: DW4H3MEGWFBEY44HB47DP7Z5CTIY7MWA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 16:39:01 +1000 David Gibson wrote: > The statement in the comment about /usr/libexec being only for running on > other hosts simply isn't true, neither in practice nor according to the > FHS spec[0]. I don't remember where I took that meaning of /usr/libexec from, I guess it's from some outdated packaging guidelines (Fedora? Kata Containers?). Sure, it makes sense to fix that. > Furthermore this logic didn't even handle it correctly, since > it would only handle binaries _directly_ in /usr/libexec, not those in > (explicitly FHS permitted) subdirectories under /usr/libexec. So, this change breaks the two cases I needed to cover with this, which are /usr/libexec/kata-agent in general, and /usr/libexec/qemu-kvm on RHEL 9. What does it fix? > [0] https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html > > Signed-off-by: David Gibson > --- > mbuto | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/mbuto b/mbuto > index a2a8147..5e8ea9c 100755 > --- a/mbuto > +++ b/mbuto > @@ -752,14 +752,6 @@ prog_add() { > unset IFS > [ -z "${__bin}" ] && err "Can't source ${1}" > > - # Binaries in /usr/libexec are meant to run on other hosts only, so they > - # can't reside in /usr/libexec on the target image. Move to /usr/bin. > - if [ "$("${DIRNAME}" "${__bin}")" = "/usr/libexec" ]; then > - __bindir="${wd}/usr/bin" > - else > - __bindir="${wd}$("${DIRNAME}" "${__bin}")" > - fi > - > "${MKDIR}" -p "${__bindir}" > "${CP}" --preserve=all "${__bin}" "${__bindir}" > -- Stefano