Re: [PATCH 3/4] test/passt.mbuto: Install sshd-session OpenSSH's split process

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 26 Aug 2024 16:41:23 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Tue, Aug 20, 2024 at 01:14:33AM +0200, Stefano Brivio wrote:
> > OpenSSH now ships a per-session binary, sshd-session, with sshd
> > acting as mere listener. It's typically not found in $PATH, so specify
> > the whole path at which it's commonly installed in $PROGS.
> > 
> > Link: https://www.openssh.com/releasenotes.html#9.8p1
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> Oops.  I reviewed by sight, but didn't test.
> 
> This breaks completely if you still have an older ssh without
> sshd-session.  That includes running on Fedora 40 as of today.

Oops, I forgot to check this on Fedora 40, and I see it's actually at
/usr/libexec/openssh/sshd-session on Fedora Rawhide.

> I'm not immediately sure how to fix this within mbuto's constraints.

Well, the profile files are shell scripts as well, so we can just look
for sshd-session in both places, and add it to $PROGS only if we find
it. I can test and send a patch in a bit.

> > ---
> >  test/passt.mbuto | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/test/passt.mbuto b/test/passt.mbuto
> > index 4abaafc..61865e8 100755
> > --- a/test/passt.mbuto
> > +++ b/test/passt.mbuto
> > @@ -13,7 +13,8 @@
> >  PROGS="${PROGS:-ash,dash,bash ip mount ls insmod mkdir ln cat chmod lsmod
> >         modprobe find grep mknod mv rm umount jq iperf3 dhclient hostname
> >         sed tr chown sipcalc cut socat dd strace ping tail killall sleep sysctl
> > -       nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp}"
> > +       nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp
> > +       /usr/lib/openssh/sshd-session}"
> >  
> >  KMODS="${KMODS:- virtio_net virtio_pci vmw_vsock_virtio_transport}"
> >    
> 

-- 
Stefano