From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YB6g6QF0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id A49915A0275 for ; Mon, 26 Aug 2024 09:55:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724658957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8fU2lDx4je91nmQvAOCTy3/b4JXoPhlhhEjd2vZIzQ=; b=YB6g6QF0pu/CYzGDOCF3D/YHDKS6tLJoX9cwbZEV6ABDeqW/nJH/pmFi6SVePPRBHwl+60 gNN7LTnz0qMDmlyL/9F2ODJdIXP7wVqNbCgQvX41lmFy8qeQNSpWFFqU7BX6stm620LLHO ZW7ndQpnlfV32bRpZgJG+YEqXnsUKhI= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-rPXyScpzNAy2j3eHhrtKlA-1; Mon, 26 Aug 2024 03:55:55 -0400 X-MC-Unique: rPXyScpzNAy2j3eHhrtKlA-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-6507e2f0615so3429170a12.1 for ; Mon, 26 Aug 2024 00:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724658954; x=1725263754; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=c8fU2lDx4je91nmQvAOCTy3/b4JXoPhlhhEjd2vZIzQ=; b=Xq5gt8NN7Ut8omLlqD7Tm/dmiXxuU9/Q1lE8RTTnuMOm+iKgNS9wlRxs4AyEjxJO1i yHl5Az+hz9R6/7oLe8/XBguigQ0//fMp56ovy2BB2YNcM+zvzDxKKzy74d98060FuoN0 uEaV4hkRvBV/XVYGZV9tDEujJhhomDzCmOxGIElemmdObtQtqX+wx5IQ+FNX478RVf5H PmsKgPNw0UXinHAt20ygrkMMENyrDZn+K3QrtJpvdLcCY/czcHxuZhPlABQzBgF9Mj3N st+nRZQ2Ngx3couA0Fk0bK7WPb2doS54jJ5D56zOKbv5UgA+4IvjtqRLcfQVJQgt54sM sb7w== X-Gm-Message-State: AOJu0YxU/4IRV1TKYMkeytNvX4oN/7Y0lnZexdwlyAyRYrbBlpObVsgE n4MoNXX6iTz8SwWAaJbfFf8916VWl4fMg20zzK3WFkVIW9t682eUJpe9cNv5DiuF8TK+ifHQK0D yV7/fqgKMCsDA+Ap1G7AgMvvVMl01sMv3OmIOSb2zf7sLEuyMFEfc72IjWQ== X-Received: by 2002:a17:902:eccb:b0:201:efe7:cafc with SMTP id d9443c01a7336-2039e4dfb95mr106699425ad.23.1724658954213; Mon, 26 Aug 2024 00:55:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbomqMrmx0HPhQ2eqCTeT8I1tQRMbX6Hxco7sEIi8zt3dthqDSER5Nu+hHzSzV+AVL2n+pOQ== X-Received: by 2002:a17:902:eccb:b0:201:efe7:cafc with SMTP id d9443c01a7336-2039e4dfb95mr106699205ad.23.1724658953687; Mon, 26 Aug 2024 00:55:53 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203855677dbsm62966815ad.28.2024.08.26.00.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 00:55:52 -0700 (PDT) Date: Mon, 26 Aug 2024 09:55:50 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 3/4] test/passt.mbuto: Install sshd-session OpenSSH's split process Message-ID: <20240826095550.4ece4c8b@elisabeth> In-Reply-To: References: <20240819231434.1481576-1-sbrivio@redhat.com> <20240819231434.1481576-4-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BE6GA7CMMWMCTKQBWBMTQMSJ4SWLQ6FU X-Message-ID-Hash: BE6GA7CMMWMCTKQBWBMTQMSJ4SWLQ6FU X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 16:41:23 +1000 David Gibson wrote: > On Tue, Aug 20, 2024 at 01:14:33AM +0200, Stefano Brivio wrote: > > OpenSSH now ships a per-session binary, sshd-session, with sshd > > acting as mere listener. It's typically not found in $PATH, so specify > > the whole path at which it's commonly installed in $PROGS. > > > > Link: https://www.openssh.com/releasenotes.html#9.8p1 > > Signed-off-by: Stefano Brivio > > Oops. I reviewed by sight, but didn't test. > > This breaks completely if you still have an older ssh without > sshd-session. That includes running on Fedora 40 as of today. Oops, I forgot to check this on Fedora 40, and I see it's actually at /usr/libexec/openssh/sshd-session on Fedora Rawhide. > I'm not immediately sure how to fix this within mbuto's constraints. Well, the profile files are shell scripts as well, so we can just look for sshd-session in both places, and add it to $PROGS only if we find it. I can test and send a patch in a bit. > > --- > > test/passt.mbuto | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/test/passt.mbuto b/test/passt.mbuto > > index 4abaafc..61865e8 100755 > > --- a/test/passt.mbuto > > +++ b/test/passt.mbuto > > @@ -13,7 +13,8 @@ > > PROGS="${PROGS:-ash,dash,bash ip mount ls insmod mkdir ln cat chmod lsmod > > modprobe find grep mknod mv rm umount jq iperf3 dhclient hostname > > sed tr chown sipcalc cut socat dd strace ping tail killall sleep sysctl > > - nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp}" > > + nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp > > + /usr/lib/openssh/sshd-session}" > > > > KMODS="${KMODS:- virtio_net virtio_pci vmw_vsock_virtio_transport}" > > > -- Stefano