From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=b7bZRqr7; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 90CC75A004C for ; Mon, 26 Aug 2024 10:37:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724661450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jwwl2N7sDbsMuHoxnFpjptUGrMQcHd9BqK50jXeXyYU=; b=b7bZRqr7d0hp+aZQFWKs/w9vlV9gS/BlTFrEcV1idHt/+05W0hTBqMFz+zQlgM7TEl7xd7 t7h7jynWahB18Ks33f3k+d/8mI8IWrG1TgrjtUzSWvAa11JqX/PMRnPUVrv9W6zPC114Ad w3SEnl3YeCAgG2oX4s3XOFYQXAnTo0U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-R4Y74Lz9PrGWqrzgj18n2Q-1; Mon, 26 Aug 2024 04:37:28 -0400 X-MC-Unique: R4Y74Lz9PrGWqrzgj18n2Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4281310bf7aso35055005e9.1 for ; Mon, 26 Aug 2024 01:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724661446; x=1725266246; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Jwwl2N7sDbsMuHoxnFpjptUGrMQcHd9BqK50jXeXyYU=; b=Nh9iW9iwJ8L1VWatQ5fd44+IodqxK6gDR1PmLZN6RA4VcCJJ9A4rfDS0zK1XkzeRpc 0CFiA1Q4ZrF45X9nYhMMLOvqsVGKHJ8SXayPbb+YKiYale1OMgRV7zPA4keA/n784V5c N6/ZFoe1Plh8PrYWX4X1iTpbqgapJDQwpAUq090lRhTQZS1sk2tU505kpLHxHnbOmaU2 cpavPqZn37MGTV1KQr9rRRS5LE9PXjA0dQyJU7dV4KFzOsqoyyaIeS/1226i4wxHFHBJ ioeugcBmLKivvq0NfdIuGW9tuQxRkExS9OUwCGEtYdC77EAXPOQle4mi/cLvI3jRCux9 lEJw== X-Gm-Message-State: AOJu0Yytua87LEEgl8ERGFuGrOnSS+4yFCWklcUWtWRgjHcqhWit9KK1 jrk3V9rekBzEFuM3ZWU384Dk+4ZpEOGK//DqPxR0JuAOOPexaGLoOgoStMEY+3LNOKcdvBQsKfS RCuqGW0MY9LUNnAxAZoQqsxTzKl/kFh6sIIOJwZXBJg3m1h5y+CMMgCkEqg== X-Received: by 2002:a05:600c:3595:b0:426:6876:83bb with SMTP id 5b1f17b1804b1-42acd57a107mr61007145e9.17.1724661446087; Mon, 26 Aug 2024 01:37:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzVB7ncbhTdxx17CDe5CxQS2ssovEXK3Xr5aW3Yp1mURI8FLMtZbiMlWD+c5xMu76mwAGgZQ== X-Received: by 2002:a05:600c:3595:b0:426:6876:83bb with SMTP id 5b1f17b1804b1-42acd57a107mr61007015e9.17.1724661445553; Mon, 26 Aug 2024 01:37:25 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abee8c2dbsm181818365e9.21.2024.08.26.01.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 01:37:24 -0700 (PDT) Date: Mon, 26 Aug 2024 10:37:23 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] Remove incorrect special handling of /usr/libexec Message-ID: <20240826103723.60e04eb6@elisabeth> In-Reply-To: References: <20240826063901.590640-1-david@gibson.dropbear.id.au> <20240826095547.43a050fd@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 23DTZA4AUO36A72TXSSIZFUOXVULLXIV X-Message-ID-Hash: 23DTZA4AUO36A72TXSSIZFUOXVULLXIV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Aug 2024 18:20:35 +1000 David Gibson wrote: > On Mon, Aug 26, 2024 at 09:55:47AM +0200, Stefano Brivio wrote: > > On Mon, 26 Aug 2024 16:39:01 +1000 > > David Gibson wrote: > > > > > The statement in the comment about /usr/libexec being only for running on > > > other hosts simply isn't true, neither in practice nor according to the > > > FHS spec[0]. > > > > I don't remember where I took that meaning of /usr/libexec from, I > > guess it's from some outdated packaging guidelines (Fedora? Kata > > Containers?). Sure, it makes sense to fix that. > > > > > Furthermore this logic didn't even handle it correctly, since > > > it would only handle binaries _directly_ in /usr/libexec, not those in > > > (explicitly FHS permitted) subdirectories under /usr/libexec. > > > > So, this change breaks the two cases I needed to cover with this, which > > are /usr/libexec/kata-agent in general, and /usr/libexec/qemu-kvm on > > RHEL 9. > > Huh.. why? Because they're not in PATH on the guest, so we can't execute them. As an alternative, we can unconditionally add /usr/libexec to it using $FIXUP. I added the lines moving stuff to /usr/bin before I implemented the $FIXUP mechanism, and I needed to run kata-agent as init. But now that $FIXUP is available, that's probably less invasive. > > What does it fix? > > I don't have a concrete case, but it would break anything where we're > including this support binary, but the "front end" binary looks for it > explicitly in /usr/libexec. Which I'd kind of expect to be most > support binary cases, since by design /usr/libexec won't generally be > in the PATH. I see. Well, given the limited time I can spend on maintaining mbuto, I'd really prefer to just fix concrete issues, but this looks obvious enough -- as long as we have another way to keep qemu-kvm usable in the guest. -- Stefano