From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible
Date: Thu, 29 Aug 2024 06:59:05 +0200 [thread overview]
Message-ID: <20240829065905.35be74c8@elisabeth> (raw)
In-Reply-To: <20240829013242.3396770-2-david@gibson.dropbear.id.au>
Nit:
On Thu, 29 Aug 2024 11:32:40 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> +/* Empheral port range: values from RFC 6335 */
> +static const uint16_t fwd_ephemeral_min = (1 << 15) + (1 << 14);
> +static const uint16_t fwd_ephemeral_max = NUM_PORTS - 1;
Maybe you could use in_port_t instead, just for consistency with
(almost) everything else, no advantages otherwise.
--
Stefano
next prev parent reply other threads:[~2024-08-29 4:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 1:32 [PATCH v2 0/3] Probe host's ephemeral ports, rather than using RFC values David Gibson
2024-08-29 1:32 ` [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible David Gibson
2024-08-29 4:59 ` Stefano Brivio [this message]
2024-08-29 6:53 ` David Gibson
2024-08-29 1:32 ` [PATCH v2 2/3] conf, fwd: Don't attempt to forward port 0 David Gibson
2024-08-29 1:32 ` [PATCH v2 3/3] fwd, conf: Probe host's ephemeral ports David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829065905.35be74c8@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).