From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eyemomN5; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 265AA5A004E for ; Thu, 29 Aug 2024 06:59:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724907552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7k/MK2TP+5ImxkX9qf+rCahxSWSfNiy6ECjTtRYyXw=; b=eyemomN5CfcqFlXFlGnxFFN8vwSjfSpQHDpF1x/t6WjDSt1cFBvgJcPL9/V+HW6Mf6zJoG tnzz87w0tLal8H5erUauF+6Oa8puCBNTApBUM1wtW1+pPqc9KOrP5QepFC3vazzjFnOrfv zCixzbnwWyPGVKb1S8IH3eBeKwgDUH4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-ihRWGw9cPMi8T3AaNDjZYw-1; Thu, 29 Aug 2024 00:59:10 -0400 X-MC-Unique: ihRWGw9cPMi8T3AaNDjZYw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3718c0b4905so207497f8f.2 for ; Wed, 28 Aug 2024 21:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724907549; x=1725512349; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R7k/MK2TP+5ImxkX9qf+rCahxSWSfNiy6ECjTtRYyXw=; b=wQwRGjL7wWtJNJgB+XW08aDuTAhkUaSwxIHvk5tiWSdiGsg9ZtMGXU/3pgivKV6E1K zqBnGP7RnCOadkgkjrrTzP5EC6YGhYx4nK9uPzE7AfPrrR2cjiCOfVzqDXQQQpLqH4M0 LjqV3QuzES3Nq2CBtnoEdBdIEB5xyfeUc8h5wnTdjoMu2SjMlryNan4iJbZzOv7JU9xK Tchs3ObkkWra7nIgavLqpzJwi0QCy6EIWhE7nuSzdywPGLM5PpdJy9OutKoEZ7R4eiRy iHIp0HXox8GBf5JZybp55N/YjuWZBBP7zr6TnCFbJ8M0NlP1sKR2Ar4FhzEzu8FIkhWn Jw7Q== X-Gm-Message-State: AOJu0Yx3rMgJxtI+/VnrSL5UA8YLNFraWFdouDVVNibKiMHqU/amyoKq SLFkjU5E/5W9W+VotsgzTcn/OaiJ63Db9bGVzJMntkDddx2lv3wDRR/OLVlanwK/KG4XaShO55z zZmbemtoAV+wqpKknp6s1P8aqjGVMAQ22OMdOvvIKOa7cPwmTFA== X-Received: by 2002:a5d:58e8:0:b0:373:54c:26a4 with SMTP id ffacd0b85a97d-3749b587517mr952134f8f.54.1724907549488; Wed, 28 Aug 2024 21:59:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/+CraoqTG0CAM2xrVOxOpniP80yrRsHRdedlMjbhKFzpgXpqQPj1mbK79h7pnRtnmqxNIuA== X-Received: by 2002:a5d:58e8:0:b0:373:54c:26a4 with SMTP id ffacd0b85a97d-3749b587517mr952126f8f.54.1724907549009; Wed, 28 Aug 2024 21:59:09 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee9c49asm424658f8f.52.2024.08.28.21.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 21:59:08 -0700 (PDT) Date: Thu, 29 Aug 2024 06:59:05 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible Message-ID: <20240829065905.35be74c8@elisabeth> In-Reply-To: <20240829013242.3396770-2-david@gibson.dropbear.id.au> References: <20240829013242.3396770-1-david@gibson.dropbear.id.au> <20240829013242.3396770-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2Q7JBUKADI644VN3DAAMQAIAZ4QKPFAZ X-Message-ID-Hash: 2Q7JBUKADI644VN3DAAMQAIAZ4QKPFAZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nit: On Thu, 29 Aug 2024 11:32:40 +1000 David Gibson wrote: > +/* Empheral port range: values from RFC 6335 */ > +static const uint16_t fwd_ephemeral_min = (1 << 15) + (1 << 14); > +static const uint16_t fwd_ephemeral_max = NUM_PORTS - 1; Maybe you could use in_port_t instead, just for consistency with (almost) everything else, no advantages otherwise. -- Stefano