From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v3 0/3] Probe host's ephemeral ports, rather than using RFC values
Date: Fri, 30 Aug 2024 09:07:20 +0200 [thread overview]
Message-ID: <20240830090720.02af31ea@elisabeth> (raw)
In-Reply-To: <20240829095847.286660-1-david@gibson.dropbear.id.au>
On Thu, 29 Aug 2024 19:58:44 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> As discussed on our recent call, this implements basing which ports we
> consider "ephemeral" on probing the host's settings, rather than just
> assuming the RFC 6335 recommended values, which are not what Linux
> uses by default.
>
> I think this is more correct, but additionally using the Linux values
> means we consider more ports ephemeral, reducing kernel memory
> consumption for -t all -u all.
>
> Changes in v3:
> * Used in_port_t instead of plan uint16_t
> * Considered using sscanf() rather than strchr() + strtol(), but
> decided against it. I can never remember exactly what is and isn't
> accepted by scanf(), plus clang-tidy complained about it.
> Changes in v2:
> * Add missing close() for the sysctl file
Applied.
--
Stefano
prev parent reply other threads:[~2024-08-30 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:58 [PATCH v3 0/3] Probe host's ephemeral ports, rather than using RFC values David Gibson
2024-08-29 9:58 ` [PATCH v3 1/3] conf, fwd: Make ephemeral port logic more flexible David Gibson
2024-08-29 9:58 ` [PATCH v3 2/3] conf, fwd: Don't attempt to forward port 0 David Gibson
2024-08-29 9:58 ` [PATCH v3 3/3] fwd, conf: Probe host's ephemeral ports David Gibson
2024-08-29 15:08 ` Laurent Vivier
2024-08-30 7:07 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830090720.02af31ea@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).