From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zc/TMJJt; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 06B355A0262 for ; Fri, 30 Aug 2024 09:07:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725001651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PuYCDaYn3BQ1Kw3znUMv/A2s0wXgfzWtkEix3+XLZ4g=; b=Zc/TMJJtdlytdeImd4qLk9I5O2YTl5UT7M9I9mJspDmGrOOcbJlDs5YJpV3sklzSIA7npr dBIGlKZD4sWCeZBG90CnFgn/NEJFG9QoJnQ1FOJs1gxSAmD2Rlcbg6JTUAJD78XQqaYz8f GZUTdnf5DsVefjASh5QMNJVyKWrTabA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-nsO4Sz81MbGNfLnf7Mfh0g-1; Fri, 30 Aug 2024 03:07:30 -0400 X-MC-Unique: nsO4Sz81MbGNfLnf7Mfh0g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42ba94a0555so13714155e9.0 for ; Fri, 30 Aug 2024 00:07:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725001647; x=1725606447; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PuYCDaYn3BQ1Kw3znUMv/A2s0wXgfzWtkEix3+XLZ4g=; b=WuO20oM7z8+Rx2aKPC31FLEIsfOK+S2w0sB4Sa8bBioH9vcWoo0Bml568e4321+srD 7rFn4BtJBhGpbhg2e5+Ch4/SJfXLpwnBLC1n84AMuLbixrBwxpongajKc2euZmJ/phtl jutBbW9cbBE88kzPQ3O+APSkVMBE7KBYcUhAZoz7VgQRGe9ootavRGEnqyfjG24JZDTu psaDuHPoNWug63WAiTKL5rctoMiDY62IaxmX4ZYf92joUgH2xCENGnwe7UNMDj7Wspl2 eWbp498MfwdERowUNEuX12NDbKUlmrokqHStikU8J8xQQFMEViwB0xEcoaS5t/GJVBTM h8rA== X-Gm-Message-State: AOJu0YzX/FNrRdN+m8DAwg4vPQIGvpmn8mgl4SOwpSa4iTQmEzxo4sfO aB9vLLnm6PQSK9uqP2b5EL7yNSvEF/RnpC0t8bF+ouJ0nCWGFrEsZattaTWTr35jSuV+3FpozIg QhFRF/E7FJuhJdNoIhgMMoz5UcRQgUvR6Sv2kSfGg6/KFLhrY5LeSrYMLVy4gZ+2CPqiC4T94Ci FeZZGfA5VE1tDQTjEaMzO7EiQCELG7ybPD X-Received: by 2002:a05:600c:46ce:b0:426:4978:65f0 with SMTP id 5b1f17b1804b1-42bb0262746mr46357005e9.18.1725001647540; Fri, 30 Aug 2024 00:07:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4+mSPzpLyuzueOBqg/x71WEb/nzzamAefzoR3fnIvVKDgxxtaZVHBgXJpQTycuhdzvdvMbg== X-Received: by 2002:a05:600c:46ce:b0:426:4978:65f0 with SMTP id 5b1f17b1804b1-42bb0262746mr46356715e9.18.1725001646882; Fri, 30 Aug 2024 00:07:26 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42b9e7b7f87sm74059575e9.1.2024.08.30.00.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 00:07:26 -0700 (PDT) Date: Fri, 30 Aug 2024 09:07:24 +0200 From: Stefano Brivio To: Michal Privoznik Subject: Re: [PATCH] Makefile: Enable _FORTIFY_SOURCE iff needed Message-ID: <20240830090724.02d00245@elisabeth> In-Reply-To: <6f3c749d01ab15eea130ddd6d879b3c7b60e191f.1724940903.git.mprivozn@redhat.com> References: <6f3c749d01ab15eea130ddd6d879b3c7b60e191f.1724940903.git.mprivozn@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: L53WECRJQHMQCFKJ2THPMV64NVB452EJ X-Message-ID-Hash: L53WECRJQHMQCFKJ2THPMV64NVB452EJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 29 Aug 2024 16:16:03 +0200 Michal Privoznik wrote: > On some systems source fortification is enabled whenever code > optimization is enabled (e.g. with -O2). Since code fortification > is explicitly enabled too (with possibly different value than the > system wants, there are three levels [1]), distros are required > to patch our Makefile, e.g. [2]. > > Detect whether fortification is not already enabled and enable it > explicitly only if really needed. > > 1: https://www.gnu.org/software/libc/manual/html_node/Source-Fortification.html > 2: https://github.com/gentoo/gentoo/commit/edfeb8763ac56112c59248c62c9cda13e5d01c97 > > Signed-off-by: Michal Privoznik Applied, thanks! -- Stefano