Re: [PATCH 0/6] RFC: Clean up tap-side event handling

[Stefano Brivio <sbrivio@redhat.com>]

On Tue,  3 Sep 2024 22:02:29 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> This is a draft patch working towards adding EPOLLOUT handling to the
> tap code, which could then be used to "unstick" flows which have
> unsent data from the socket side.  For now that's just a stub, but
> makes what I think are some worthwhile cleanups to the tap side event
> handling in the meantime.

Except for the issue in 3/6 and nits elsewhere, it all makes sense and
tap-side EPOLLOUT handling is definitely going to be an improvement.

I wonder if it's the right moment for this kind of series, though, in
terms of future bisections, as long as we're grappling with
https://github.com/containers/podman/issues/23686 and
https://bugs.passt.top/show_bug.cgi?id=94. Assuming, of course, that
this series doesn't fix anything.

That is, once/if we come up with fixes for those, as they might involve
setting different event masks, I'd rather have those in *before* this
series, to avoid further noise in case we manage to break something
else with those hypothetical fixes.

-- 
Stefano