From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ne/vLmLw; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id C34D65A004F for ; Tue, 03 Sep 2024 21:26:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725391561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YO504iwrq67ZsQiniemgwL44Gogg+MvQI0/apV5/jhQ=; b=Ne/vLmLwkIlEE0pigc/QieqGeONFTDnDZfOE/uRxudgh8fgTEkCgdECGi6HUNkFPbQRJSl v63sFRRAxi3hhNvopBAsgnRiQBt40TUw1TC3v5QGF5v8MuZICYvDJ8qVoaT9ESwvYDZHMA rb0bB115F7T/3TpcJTWfN5+PCgbrCbc= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-dYkZB1nVNiq0CItAX9dKlA-1; Tue, 03 Sep 2024 15:26:00 -0400 X-MC-Unique: dYkZB1nVNiq0CItAX9dKlA-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-7cda25df5a5so4786396a12.3 for ; Tue, 03 Sep 2024 12:26:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725391558; x=1725996358; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YO504iwrq67ZsQiniemgwL44Gogg+MvQI0/apV5/jhQ=; b=qcGiKvQcz3b7q9KpXofcwaBKYgtP52m8uVYrHj0CFTVLHTQH7O45K6CeWGXeGW0u4a Pygft62DigsuLsWvFj70aGF2MbwYHz1rJ2vUpnUbppVUYX8h0s92WVMBVLcXAi7tPcrm ZSATf+sasrTdDcF94CNxZs47pddpvR+Sdl8wT9SVvUw2pS77Ld1dZQxjm8W9xMEkotSc zgZCm566n4zhngm3BhAIJHUQx8yAzy9ExYpTGr4nhOfez0VErVbILLjUBYzlu16OycK4 PV8Ug09P3sCL0h8noNKvf6225GFyZvdoN4MNjIs/BK/tR+4UtqC5XmPnpbUo5VgrNDnH pszQ== X-Gm-Message-State: AOJu0Yyj40uNnBMn+0o64Z5FaFsbxF7faeS7OlCK4RxYVdSdHEeQ0SQq va4Vq/fBfkGBIHkPTqQS6h+oggf9sVQ/O96J8ChOSirHDw0fYbWr1cLq8ziCaBloJLkxV6whVaU b3OalHoN9QTmZRUF7wjObMCWyIaUzDqOeTVId4HfkuRclPxz0aGEeDz1RDQ== X-Received: by 2002:a05:6a20:78a5:b0:1ce:efc5:6664 with SMTP id adf61e73a8af0-1ceefc567cemr5111449637.5.1725391558498; Tue, 03 Sep 2024 12:25:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpsfMPdtBRupJs7iNI7EAx0nhV+FJrjYRL88+bPNhnIFGbPXCmoMFWFw/RcyEBTs2lhVKzow== X-Received: by 2002:a05:6a20:78a5:b0:1ce:efc5:6664 with SMTP id adf61e73a8af0-1ceefc567cemr5111428637.5.1725391558115; Tue, 03 Sep 2024 12:25:58 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-717785b4e24sm219078b3a.206.2024.09.03.12.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 12:25:57 -0700 (PDT) Date: Tue, 3 Sep 2024 21:25:54 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/6] RFC: Clean up tap-side event handling Message-ID: <20240903212554.036da194@elisabeth> In-Reply-To: <20240903120235.1688429-1-david@gibson.dropbear.id.au> References: <20240903120235.1688429-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CT22SRQZXUMZ66LPKOENYH5QRBPSVVQF X-Message-ID-Hash: CT22SRQZXUMZ66LPKOENYH5QRBPSVVQF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 3 Sep 2024 22:02:29 +1000 David Gibson wrote: > This is a draft patch working towards adding EPOLLOUT handling to the > tap code, which could then be used to "unstick" flows which have > unsent data from the socket side. For now that's just a stub, but > makes what I think are some worthwhile cleanups to the tap side event > handling in the meantime. Except for the issue in 3/6 and nits elsewhere, it all makes sense and tap-side EPOLLOUT handling is definitely going to be an improvement. I wonder if it's the right moment for this kind of series, though, in terms of future bisections, as long as we're grappling with https://github.com/containers/podman/issues/23686 and https://bugs.passt.top/show_bug.cgi?id=94. Assuming, of course, that this series doesn't fix anything. That is, once/if we come up with fixes for those, as they might involve setting different event masks, I'd rather have those in *before* this series, to avoid further noise in case we manage to break something else with those hypothetical fixes. -- Stefano