From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gpvGLC5m; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id A4CC65A0262 for ; Fri, 06 Sep 2024 13:30:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725622201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+F8Upjc40DYO4JHkUBEkHAM+DJz3ytbRAmPLCOAPHU=; b=gpvGLC5mnPziCk5oATS3EJdrSfOHwHhtgJAWAtfTT4Hn1kJYMTxjYfLtneoEH/t06eWJpy nO5KlSzHj2YxDmAV896xf86c7WpVhL9G4w9lQ/XKqxuk4rQIfM6K7nNmSCiBMX9/TWpt8F Z/ARqcLyyUNju5E8r9Dn52K4ijiCXDo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-CkCNCqI9NDGHUDXjbFXSrA-1; Fri, 06 Sep 2024 07:30:00 -0400 X-MC-Unique: CkCNCqI9NDGHUDXjbFXSrA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42c7aa6c13cso15060005e9.1 for ; Fri, 06 Sep 2024 04:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725622198; x=1726226998; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=H+F8Upjc40DYO4JHkUBEkHAM+DJz3ytbRAmPLCOAPHU=; b=eq/uYT6DBcl0dW3pEAT4/gUhAcoE2vTsRzEsEKX+ZXQYwUYr909jLAP6SUU3iXJdRR dWvfM+MW9W+r/EyWEV7gcCGi23hsxwQK6LAXgd4i5ELZJc8zRh9RLtH9QhUpKFMuxbUa Cx5xER7hxUfsqKqwPsRnQZ1rY1BlaRvK+R/0+FMZIVhXN3HWKPRQFy2nxkJRIb7ze+a6 zqymlqvMH4MwlIxpHenj1FTe5Iv+z4bNeJs8RUooNjRAxUW3ie+ad2xvLbr5oWn7scbk e9crQiGitd2qaPfaVIkTG1cTanDoon2QYwUSBbmENF8yQ4iVMpi9cb0Y3+sF83gRzJrf MYdw== X-Gm-Message-State: AOJu0Yw1RWBAHRMaGkFwAeshE5eFcTJ0nHTexCSWJvqZULvOM7MJoMoc LAHPypmNZwFM1AHg4Z+kxJJhS4nK0TwvuaLe8/aT6D1LCYVimyB8W3jUS7Y/uhXCXGAaN+J8hMY hit+XaU62BG+DUviOunDX659i7fRg25hCnYMTL5ar2rIhCnyDIhujNOR/hw== X-Received: by 2002:a5d:6905:0:b0:374:c454:dbb3 with SMTP id ffacd0b85a97d-378896a00b4mr1214583f8f.55.1725622198578; Fri, 06 Sep 2024 04:29:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYK07B+uhH+rJtPW6D61EKHKBe2je0Zpa/2AMs6IQUaUxzviAMskJFc1TI0HCjQqPIYPjljQ== X-Received: by 2002:a5d:6905:0:b0:374:c454:dbb3 with SMTP id ffacd0b85a97d-378896a00b4mr1214546f8f.55.1725622197785; Fri, 06 Sep 2024 04:29:57 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ef812cbsm21591184f8f.83.2024.09.06.04.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 04:29:57 -0700 (PDT) Date: Fri, 6 Sep 2024 13:29:55 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/6] RFC: Possible fixes for bug 94 and bug 95 Message-ID: <20240906132955.402dee4a@elisabeth> In-Reply-To: <20240906051710.3863211-1-david@gibson.dropbear.id.au> References: <20240906051710.3863211-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HGIM7SDF2ACW2P26QKPKDQJ5KDRJNQ2R X-Message-ID-Hash: HGIM7SDF2ACW2P26QKPKDQJ5KDRJNQ2R X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 6 Sep 2024 15:17:04 +1000 David Gibson wrote: > As discussed on IRC through the last day, here's a more polished > version of possible fixes for bug 94 (EPOLLRDHUP storm) and bug 95 > (EPOLLERR storm). Both of those were sub-problems arising while > investigating podman bug 23686. > > We're pretty confident about the EPOLLRDHUP fix (bug 94, patch 1/6), > based on Stefano's testing. I ended up rewriting Stefano's draft > patch for the EPOLLERR case (bug 95, remaining patches), because I > thought of a possibility we hadn't discussed yet: we weren't getting > an error from the socket error queue, but we might be able to get one > with the SO_ERROR getsockopt(). My examination of the kernel code > suggests that's plausible, and that if that's the case using SO_ERROR > should also clear that error condition. > > Link: https://bugs.passt.top/show_bug.cgi?id=94 > Link: https://bugs.passt.top/show_bug.cgi?id=95 > Link: https://github.com/containers/podman/issues/23686 Applied. -- Stefano