From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YKeiRrt/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B4AE95A004E for ; Fri, 06 Sep 2024 14:20:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725625212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/B0jeqmpxUzAiIFPwvIOCHUQZMUshp2aY6aEPxBBHo=; b=YKeiRrt/OXYEOKd2s1P/ca2GteoximKW7jEnBcIv+1Y3/fgRrj/lj3zecdGEN0XsVPVkOV JY4Am6C1gZ6PG7NHY/r3vb3+evZV3EP6okn4uTYPHdgwidTVI8WbFzIhqMwC4sIoqSmOE7 zrLSk5iVFBcQLvxuAeVKSkesQYdAFDg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-31MecyIaO3yRaUnVVKBfdw-1; Fri, 06 Sep 2024 08:20:11 -0400 X-MC-Unique: 31MecyIaO3yRaUnVVKBfdw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-374c301db60so1223297f8f.2 for ; Fri, 06 Sep 2024 05:20:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725625209; x=1726230009; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=r/B0jeqmpxUzAiIFPwvIOCHUQZMUshp2aY6aEPxBBHo=; b=v3y69g+kXKNJoXGmPqAwfFiwfRQD2k8uQrd7vhx+LFexVl3G++vdwk0GpsVGBH3APP I0cajOJV6soaoKlzgI0vMn1m/3LBOXzkIzZ2YcdFumcNSO92XMTSdgnn15MY0hYiEQiH lx3UASCn2QZ1Gmok3yHDqYls9xlyAPhRktyEXE3o+0JcT9aEiWFXuVxwpOGhjfZ3KgGE M8BbMNtz3h6pU0/if0q5RNQRfI6fSpSHt0wJYmqAeVzikWsc2MId4v3DyA7m0kDiWGeN wTDAynrDstsyGR/oNFyNkQE3OyAykB2XrJMdDceXfxeGLFoQ0VNrCZ2IzvNJPR14D8ew K2rg== X-Gm-Message-State: AOJu0YxaRtyt7J7sHUFxyCmxTwRZ7m4daKrSK4BmJD6XaQAtkddf/bWt bAqFLJSvCwoIWgR0/YBS4C9Di5EO8cxITKTVaH4iRktoszJceULpJJTxHemsP4DQimOnZOpH6Vj wejz6x2gCSeS64tzIT4Jyv6bHlWOQdxpFOCsEu/BDQLIndbVydYf+eXq1Bw== X-Received: by 2002:a05:6000:50d:b0:371:a70d:107e with SMTP id ffacd0b85a97d-3749b53169bmr20788862f8f.6.1725625209459; Fri, 06 Sep 2024 05:20:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIFsUkxl56UVr8uklwXBUhdTO/nLffQv7avGN/cu9Aa83UaDHfND9NemCZ8QPtMreCenE5tg== X-Received: by 2002:a05:6000:50d:b0:371:a70d:107e with SMTP id ffacd0b85a97d-3749b53169bmr20788852f8f.6.1725625208980; Fri, 06 Sep 2024 05:20:08 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ca05c26b1sm19145385e9.9.2024.09.06.05.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 05:20:06 -0700 (PDT) Date: Fri, 6 Sep 2024 14:20:04 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] Fix possible truncation of frames from /dev/net/tun Message-ID: <20240906142004.15775b3f@elisabeth> In-Reply-To: <20240906114939.261097-1-david@gibson.dropbear.id.au> References: <20240906114939.261097-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NJAJUHT5LAXKGNTAPCDBQRYRLZ6JT7KU X-Message-ID-Hash: NJAJUHT5LAXKGNTAPCDBQRYRLZ6JT7KU X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 6 Sep 2024 21:49:35 +1000 David Gibson wrote: > These changes started off as part of the series re-introducing EPOLLET > for tap event handling. That's now turned out to be of lower > priority, but along the way we fixed a bug where we could truncate > frames from the kernel tap interface. > > This is a respin of that patch, plus a few minor preliminary cleanups. > Various minor tweaks based on feedback from the original posting as > part of the tap EPOLLET series. > > David Gibson (4): > tap: Split out handling of EPOLLIN events > tap: Improve handling of EINTR in tap_passt_input() > tap: Restructure in tap_pasta_input() > tap: Don't risk truncating frames on full buffer in tap_pasta_input() Applied. -- Stefano