From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ml3+fd2x; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 9080B5A004E for ; Thu, 12 Sep 2024 09:54:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726127655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z+N+wl+WbsNw/hb06OO7KwzYsB/oiua2OBcecBB5wgk=; b=Ml3+fd2xKQI7a67H3K2/Kf5/3DJMQo2dQwRPkMGjpOGTpxqQKG4fNikaOxFIywRMTIAJgl p41fusu2sxOo38TFxv1e1j/DKV4kiXtR03HlN+Fv1snsTkgVYBbGtKr+/PMeC6AtXYW2nu EVYM6GgpCSVa23PZ8XwqvmEJFgEVEvg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-F7VnGZhxMZOSXtGIvPOK1Q-1; Thu, 12 Sep 2024 03:54:12 -0400 X-MC-Unique: F7VnGZhxMZOSXtGIvPOK1Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb830ea86so4561035e9.3 for ; Thu, 12 Sep 2024 00:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726127651; x=1726732451; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z+N+wl+WbsNw/hb06OO7KwzYsB/oiua2OBcecBB5wgk=; b=SyutKn8qYJQMjidr+GBqTyZkRO2gIXWSiXmCQPg96FSosULctyGK5NH+f/KaUcLR5D 3PwEq2X08QbaWH/fMJBKhIrre73fw/Ge1nHixQoJzGogGSPbn5ud/LjfdVwtMEKSLuPu E0iqKkpPdoh0B5BDlLNvkT0Eey1ARP0nd2BH6nMmpeaM1Ww3eya4DA5QtZRxzHs0qdcf wWLqoCBtmx+g0fhvh27wEo2895HAPBfl2gHJqg45g6MjgpShHY67NwszAxLmsEORrQjc mgm2k5yV+S/9sCNw4IwLg5Ivk31rc6zXLcK8jsItn8FqWVAU98IGfnxhOfaMqAALbxke 4nmQ== X-Gm-Message-State: AOJu0YwrWcrjg/RmNK7BYw7TmLEGztZyucKs9SAOGStkBMMJ1iXoO41d l8ziyMOUGOgbl5dlaC8qS3MlLBu2c/OJrMJ6bACEl9IUQHhRD2KMcrTG7bE8bM+sDPuMkLUI6bq GAnx8/FdG03r40H22FSplboalM9ZsG4MeGL3rdKBFae/k9TgyAavjFJZiRQ== X-Received: by 2002:a05:600c:1c1a:b0:42c:b037:5f9d with SMTP id 5b1f17b1804b1-42cdb4e6a7bmr15094015e9.3.1726127650811; Thu, 12 Sep 2024 00:54:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaKRvhxJUqnNC+lDSjeJe85zlVfUHzCRdBPvAbMc1raMC/3c0bPAcDUyOqJ1kHMzFtEplZ/g== X-Received: by 2002:a05:600c:1c1a:b0:42c:b037:5f9d with SMTP id 5b1f17b1804b1-42cdb4e6a7bmr15093635e9.3.1726127649453; Thu, 12 Sep 2024 00:54:09 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956de00fsm13592373f8f.99.2024.09.12.00.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:54:07 -0700 (PDT) Date: Thu, 12 Sep 2024 09:54:06 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/2] Avoid overlapping mempcy() in DUP_ACK handling Message-ID: <20240912095406.0448afc5@elisabeth> In-Reply-To: <20240912065940.1738239-1-david@gibson.dropbear.id.au> References: <20240912065940.1738239-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: Q5WGJ67QWZNVSEGJJWMYDRQDLXCTJ53Y X-Message-ID-Hash: Q5WGJ67QWZNVSEGJJWMYDRQDLXCTJ53Y X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 12 Sep 2024 16:59:38 +1000 David Gibson wrote: > Spotted this so-far harmless, but technically undefined behaviour > while looking at other things. Fixed one other nit at the same time. > > David Gibson (2): > tcp: Remove redundant initialisation of iov[TCP_IOV_ETH].iov_base > tcp: Avoid overlapping memcpy() in DUP_ACK handling > > tcp_buf.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) Applied. -- Stefano