From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=m0jis4xP; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6A6435A004C for ; Fri, 13 Sep 2024 06:32:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1726201936; bh=uOWdkmGfor+TiBxMn6XRsKj6s6v9Gb8zt3W4zXZ5IEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m0jis4xP0JQVhk1qp0XkPsy3Gb1XW9CIwMpHTRWK0wNoCOO3X3Vgs4F2fQah0GfyY v5WZAYQkaTQIm107DX0bHuzQvvNsBMJVmaGY473NoK15vMLfQCr+WxM7KBDQxGvI2b ZaidzvcIiIX5kcSEDlsxsFXdyQGa9gZEVuMCLL8Azi1Q23gPr3zpxN2k3H597wuDj+ 083yzoT8qFQfyrUzSqrL5DMHJ+vS57iKuVFe9SdpYPaaDcGFfrFpyvf86ZabqJwgoI DMPQQo1efF/DslLWnnMIfjXNhqYsNkXLTFrixuUhOMG6Xc9JwglpZ/smNtQ8dL99We rOknnctyFIqOA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4X4hH45NySz4xPy; Fri, 13 Sep 2024 14:32:16 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 01/10] tcp: Make some extra functions private Date: Fri, 13 Sep 2024 14:32:05 +1000 Message-ID: <20240913043214.1753014-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240913043214.1753014-1-david@gibson.dropbear.id.au> References: <20240913043214.1753014-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: AR5B65M7OQ4GHZXSEUXWSBW6AWHVY3F3 X-Message-ID-Hash: AR5B65M7OQ4GHZXSEUXWSBW6AWHVY3F3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: tcp_send_flag() and tcp_probe_peek_offset_cap() are not used outside tcp.c, and have no prototype in a header. Make them static. Signed-off-by: David Gibson --- tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcp.c b/tcp.c index f9fe1b9a..14b48a84 100644 --- a/tcp.c +++ b/tcp.c @@ -1235,7 +1235,7 @@ int tcp_prepare_flags(struct ctx *c, struct tcp_tap_conn *conn, * * Return: negative error code on connection reset, 0 otherwise */ -int tcp_send_flag(struct ctx *c, struct tcp_tap_conn *conn, int flags) +static int tcp_send_flag(struct ctx *c, struct tcp_tap_conn *conn, int flags) { return tcp_buf_send_flag(c, conn, flags); } @@ -2477,7 +2477,7 @@ static void tcp_sock_refill_init(const struct ctx *c) * * Return: true if supported, false otherwise */ -bool tcp_probe_peek_offset_cap(sa_family_t af) +static bool tcp_probe_peek_offset_cap(sa_family_t af) { bool ret = false; int s, optv = 0; -- 2.46.0