public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com
Subject: Re: [PATCH v2 0/2] tcp: unify IPv4 and IPv6 tap queues
Date: Sun, 15 Sep 2024 10:25:34 +0200	[thread overview]
Message-ID: <20240915102534.6316688f@elisabeth> (raw)
In-Reply-To: <20240914003718.2871567-1-jmaloy@redhat.com>

On Fri, 13 Sep 2024 20:37:16 -0400
Jon Maloy <jmaloy@redhat.com> wrote:

> This should save us some memory and code.
> 
> ---
> v2: - Setting pointers to pre-set IP and MAC headers on the fly
>       instead of copying them.

Thanks, at a glance this looks much safer than v1.

I didn't review in detail and didn't test, yet.

-- 
Stefano


      parent reply	other threads:[~2024-09-15  8:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-14  0:37 [PATCH v2 0/2] tcp: unify IPv4 and IPv6 tap queues Jon Maloy
2024-09-14  0:37 ` [PATCH v2 1/2] tcp: set ip and eth headers in l2 tap queues on the fly Jon Maloy
2024-09-16  1:25   ` David Gibson
2024-09-14  0:37 ` [PATCH v2 2/2] tcp: unify l2 TCPv4 and TCPv6 queues and structures Jon Maloy
2024-09-16  1:57   ` David Gibson
2024-09-17 22:34   ` Stefano Brivio
2024-09-15  8:25 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240915102534.6316688f@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=dgibson@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).