From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cI8fvvA/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 628835A004C for ; Sun, 15 Sep 2024 10:25:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726388742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qs0zalQo3qsWIIWx720sVQT8BDC/Q0dYkZ0DVnNrI04=; b=cI8fvvA/Ko6rCgOapBFRhWuBzGH3yjmo0ZDdBJFb7Pyx0YoVZIsbGtJgllX0TpWGkvSok9 JpLnK3SNgxRSj+9C3DIqqJBRFh17fsEsl8Vek6LgyK63MIk2ZUg8k1avSy0tJP8Ht9gfo/ At0MVbthWP0dj2pUbDZ7mh7Dz9/SDNU= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-pt4gGjKjPuGWNbgBrwgCVw-1; Sun, 15 Sep 2024 04:25:40 -0400 X-MC-Unique: pt4gGjKjPuGWNbgBrwgCVw-1 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-718d7ec6ff8so3645627b3a.1 for ; Sun, 15 Sep 2024 01:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726388738; x=1726993538; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qs0zalQo3qsWIIWx720sVQT8BDC/Q0dYkZ0DVnNrI04=; b=rUzkB69GfPSk402leGr/wy2imh0egOj5WUGJ9gPBJ1L1r5tShnEGfk+98qt68ynwLf /BcE9rpuunVrACO5DCYKAj6PlBNLijLfqyq2UPt25kq/QNvCaJlHDUVKgWOhGWBHr5eU /VqEs4one9iwKixTPGCz+VtbG0BeyxAwaOiSpKm//I2TtEIED7PMJXWHYAvoaVMcZCaO oMaz8WW9IQl4yJiQJrWOFKnmgirrSX+3/32Fym2VkPhVC78eGKkLau4jGm1Uancp4ZSV L9rcgUFprPjp2pAhd5aQIUG6qJP09Q8AkDqv97qKNgekQ1STPJ5AbyMANtfoXZPf6hCj HQlA== X-Gm-Message-State: AOJu0YwvrYG35WZEipLL7/RnMgyYG5SxHKHSekCAv+BQWPr5buPt+hOg OyQ4az6/I/qqQlDU+JbvnMD+nritiy13OzV17CVPOen42Rw58PkwM79rC1BTRwfbKYcdbYreUvS 3zeZNeyQ+GM+rEn6yxh17xqt0WQyMJUSuhUkplkqbOCuRTSmJ4UnktBqnrQPIxBDpJn3R6xHkXw /B1Y/L6ZEPNnWO9P2qZb2ENwrSQoJSjUSQ X-Received: by 2002:a05:6a00:3e27:b0:714:228d:e9f2 with SMTP id d2e1a72fcca58-719263a954amr17808442b3a.3.1726388738163; Sun, 15 Sep 2024 01:25:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELqi2PYpDGfFvhfgLjGH9kPNMkFyb6OAjLVRfgLGqWNoAP3hoIb45SR0jN/4fPjZmM8SzrcA== X-Received: by 2002:a05:6a00:3e27:b0:714:228d:e9f2 with SMTP id d2e1a72fcca58-719263a954amr17808421b3a.3.1726388737641; Sun, 15 Sep 2024 01:25:37 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db5616b21dsm515247a12.6.2024.09.15.01.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2024 01:25:37 -0700 (PDT) Date: Sun, 15 Sep 2024 10:25:34 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v2 0/2] tcp: unify IPv4 and IPv6 tap queues Message-ID: <20240915102534.6316688f@elisabeth> In-Reply-To: <20240914003718.2871567-1-jmaloy@redhat.com> References: <20240914003718.2871567-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ENLHZBD4RGATSEF64LT56LJZN5WUGWWB X-Message-ID-Hash: ENLHZBD4RGATSEF64LT56LJZN5WUGWWB X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 13 Sep 2024 20:37:16 -0400 Jon Maloy wrote: > This should save us some memory and code. > > --- > v2: - Setting pointers to pre-set IP and MAC headers on the fly > instead of copying them. Thanks, at a glance this looks much safer than v1. I didn't review in detail and didn't test, yet. -- Stefano