From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JQ1tVR+y; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 1B7FD5A004C for ; Wed, 18 Sep 2024 00:34:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726612462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WwNo3jfklQYI9eBHTakoWaK73grDL/WxdpblOGZtl/E=; b=JQ1tVR+yA9zPj0DkvpamlwEi+Khfam/S0EuUbArvsCTyI8sH4SRnoaHWkCx2detg/ZWoY2 ntwN7I6kkn1XU8SqebbRDzcOuLz5dMGzUmOiWEH6rRseyaN+B4mYjj4ysYuDJDnLntnq7y hzMSyiQ03D8I4JV2UKTCUhdc4CNsAHc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-KA5ByZ-vMgyCcQEIMkbxfw-1; Tue, 17 Sep 2024 18:34:21 -0400 X-MC-Unique: KA5ByZ-vMgyCcQEIMkbxfw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42caf073db8so48143595e9.3 for ; Tue, 17 Sep 2024 15:34:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726612458; x=1727217258; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WwNo3jfklQYI9eBHTakoWaK73grDL/WxdpblOGZtl/E=; b=qdzdJMa3vTC/p3RNxggRykcIQWUD8QLknOhZ79skhUfFFXXLhXHgv4+qWlptJlmzpY ruCUDS3HtMTX3cK/XnWnjFgb2nDuE3RqOmyPsfQMffOBCYozqSZPQckcSKTEJSobEtky GBY1/ABVnifsTDD8caDcCUvuN5EBTqgtcKT11EeT/fFZyzmLVTj+XIKX+iLyjddxJFMX B+WMlG4/ud7HkHSZjxcVP8Zbwy5JV9ZaY3f/m873h9+H1n/pLp7Ps0Hgih6rCTCg9Z8A galm2gx0z52IqbDwLToTPdU3PZ0JAZxLu/VLEuRX6FAWptl228ptNC4+l3ckugtGOZCA yTQQ== X-Gm-Message-State: AOJu0Yze0oY1lfwLoPh+M8HRyo8uTaVuTx7EIt2C63Y5dOH1jidR9mAW gNAvEVTtO9J027tnPQ2guzYgsG0mFN72fKP/EZjN8mrwDkPYDAz+ledkt0gJYzOpYb1yhqiAhFj FZDAXGhEr9xAXgxMhqXxWLRCxPrCjqh4AszLsCpAY9th2emtnvOSCU4KQBrNnVNXRRc/FKVRmxU Rmmic87mapvfPwrUxNkYftYBanId5kAska X-Received: by 2002:a05:600c:5125:b0:42c:cd88:d0f4 with SMTP id 5b1f17b1804b1-42cdb56aea6mr165752975e9.22.1726612458460; Tue, 17 Sep 2024 15:34:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkGOW48Fzo4ExGAQ32tkypCZ1iG8SGbtx5tOvH7koJbRIO+tjx0FWLW9yU0MjPZDIQOLW+eA== X-Received: by 2002:a05:600c:5125:b0:42c:cd88:d0f4 with SMTP id 5b1f17b1804b1-42cdb56aea6mr165752815e9.22.1726612457844; Tue, 17 Sep 2024 15:34:17 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e705090bcsm93445e9.26.2024.09.17.15.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 15:34:17 -0700 (PDT) Date: Wed, 18 Sep 2024 00:34:15 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v2 2/2] tcp: unify l2 TCPv4 and TCPv6 queues and structures Message-ID: <20240918003415.08618422@elisabeth> In-Reply-To: <20240914003718.2871567-3-jmaloy@redhat.com> References: <20240914003718.2871567-1-jmaloy@redhat.com> <20240914003718.2871567-3-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: G3LBTK7HDR3ALN3ZQBZYEH72FP6NE4DZ X-Message-ID-Hash: G3LBTK7HDR3ALN3ZQBZYEH72FP6NE4DZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On top of what David already noted, this needs a rebase after commit 5ff5d55291d2 ("tcp: Avoid overlapping memcpy() in DUP_ACK handling"). Similar to v1, I'm still getting a iperf3 hang in the "TCP throughput over IPv6: host to guest" case of the perf/passt_tcp test. I had a quick look: the server doesn't seem to be getting any frames, while both handshakes (control and data) succeed and the client is actually sending some frames at the beginning. I guess it's because of this condition: ((v4 && tcp_payload_used + fill_bufs > TCP_FRAMES_MEM)) in tcp_buf_data_from_sock(), also reported by David. If you have IPv6 frames only, you'll never flush the queue, I suppose. One nit about the commit message: On Fri, 13 Sep 2024 20:37:18 -0400 Jon Maloy wrote: > Following the preparations in the previous commit, we can now remove > the payload and flag queues dedicated for TCPv6 and TCPv4 and move all > traffic into common queues handling both protocol types. > > Apart from reducing code and memory footprint, this change reduces ...I insist that in a general case this patch doesn't reduce the memory footprint. If both IPv4 and IPv6 are enabled, then yes, but that's because it also cuts in half the number of available buffers. The series looks otherwise good to me. -- Stefano