From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P+qDGYO0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5FF6D5A004E for ; Wed, 18 Sep 2024 08:04:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726639487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlnDqhg2WqzPqLTJTqVx9jUQfTAVETZeHCDlh1eSBgA=; b=P+qDGYO0Rc2FR0iS7RodYD7mcMNPueeHRFb2ANjVo1/PLTaK7qrUwdr6a1NEV45kZW9R6k w4gemi/CanZmGHKuHOy++aDwZoFL6DjffCYNsS3IYFWcSzwUaD0onro8CrE3Er64tITn51 5jluPhtK0LPfLZBcKvR7/Rby0tsMLCc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-320-zBsoperHMZ-xrL9J44hfcg-1; Wed, 18 Sep 2024 02:04:46 -0400 X-MC-Unique: zBsoperHMZ-xrL9J44hfcg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42caca7215dso41510205e9.2 for ; Tue, 17 Sep 2024 23:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726639485; x=1727244285; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nlnDqhg2WqzPqLTJTqVx9jUQfTAVETZeHCDlh1eSBgA=; b=LL5N03hMBcbA3SfM57bIDK8kW5SnCDIynXuGoq3f2hBzeZ79UcEPTAkPQx7MCnKjAH V5Ak41s3NEiuBpUnTSK0prHLtAsJ1h9HMepvLG1+wwz2KwATu78lc8nsQWqXpbKB20E9 aIawz4we2H1TNkdrEzPyFQoYqFCwMKKMNZu0LVZSAgwLO+Pf2X53MXtcA4UKDtnlu1EJ jRCOrVZ5rADzBr32UPhfsPBOIXCfOgFRyxtMskfU2WiYmjgVxfgJICWG7RTxfjzMdsvr 1cZK27vDZW+zwUFcisw6y7oLPAW8QElG+qWmgo4ctARtDsmkuiEo/AZ8s3GHHaNWP/Ct A8Kw== X-Gm-Message-State: AOJu0Yz1Sn1qm68SHrifzQf1mAEyK4tuSAwVKSfRJP7d1Ur/+4TSlUqK l3Bi98WIWxMnP/FDDxM8H+jtCt/EvMSg7X6hV0wjsaOegQumxtpl1yDyEmRfLBcbQLkhlp1Zlzl L6IPO1iGwqF4YQ2tORcUdS58NtbeagNx5ZkKfA/jRfdnKnnJcaw== X-Received: by 2002:a05:600c:3595:b0:425:7884:6b29 with SMTP id 5b1f17b1804b1-42cdb53f541mr142973455e9.19.1726639484808; Tue, 17 Sep 2024 23:04:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IER26XDCM3yJXEs1/6XpLEDVwuXgGGuLbR5lgbGnDmuYxa26p08NBZR+JBdKa5ICbEdrKrg1A== X-Received: by 2002:a05:600c:3595:b0:425:7884:6b29 with SMTP id 5b1f17b1804b1-42cdb53f541mr142973245e9.19.1726639484198; Tue, 17 Sep 2024 23:04:44 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e704d83b5sm7390945e9.1.2024.09.17.23.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 23:04:42 -0700 (PDT) Date: Wed, 18 Sep 2024 08:04:41 +0200 From: Stefano Brivio To: David Gibson , Laurent Vivier Subject: Re: [PATCH v2 1/2] udp: Allow checksum to be disabled Message-ID: <20240918080441.23cc40f9@elisabeth> In-Reply-To: References: <20240917073058.3666887-1-lvivier@redhat.com> <20240917073058.3666887-2-lvivier@redhat.com> <20240918010650.417b2dbe@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7YEV3PLQOUMWXCUMWZFYGIGO62JJAVIE X-Message-ID-Hash: 7YEV3PLQOUMWXCUMWZFYGIGO62JJAVIE X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 18 Sep 2024 09:41:37 +1000 David Gibson wrote: > On Wed, Sep 18, 2024 at 01:07:00AM +0200, Stefano Brivio wrote: > > Nits only: > > > > On Tue, 17 Sep 2024 09:30:57 +0200 > > Laurent Vivier wrote: > > > > > We can need not to set the UDP checksum. Add a parameter to > > > udp_update_hdr4() and udp_update_hdr6() to disable it. > > > > > > Signed-off-by: Laurent Vivier > > > --- > > > > > > Notes: > > > v2: s/UPD/UDP/ > > > > > > udp.c | 41 +++++++++++++++++++++++++++++++---------- > > > 1 file changed, 31 insertions(+), 10 deletions(-) > > > > > > diff --git a/udp.c b/udp.c > > > index 2ba00c9c20a8..95151efb9c46 100644 > > > --- a/udp.c > > > +++ b/udp.c > > > @@ -298,11 +298,13 @@ static void udp_splice_send(const struct ctx *c, size_t start, size_t n, > > > * @bp: Pointer to udp_payload_t to update > > > * @toside: Flowside for destination side > > > * @dlen: Length of UDP payload > > > + * @no_udp_csum: Do not set UDP checksum > > > > The description of all the other arguments are aligned, with tabs. You > > could just add one tab to all the others and have them aligned. > > > > Actually, this could simply be 'no_csum', it's obviously UDP. Same for > > no_tcp_csum in 2/2. > > I had been going to suggest the same thing, but then I realised the > current name does disambiguate it from the IPv4 header checksum. Ah, right, never mind then. -- Stefano