public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 0/2] util: Fix some problems in write_remainder()
Date: Wed, 18 Sep 2024 20:44:04 +1000	[thread overview]
Message-ID: <20240918104406.3050878-1-david@gibson.dropbear.id.au> (raw)

With Markus Armbruster's help I re-examined the Coverity warning we've
had in this function for a while.  While I still don't understand some
steps in the report it's giving, I did spot some real problems in the
vicinity.  It turns out fixing those also fixes the Coverity warning,
so here we go.

Changes since v2:
 * Handle EINTR within write_all_buf() (suggested by Markus
   Armbruster)

David Gibson (2):
  util: Add helper to write() all of a buffer
  util: Remove possible quadratic behaviour from write_remainder()

 pcap.c |  3 +--
 util.c | 50 +++++++++++++++++++++++++++++++++++++++++---------
 util.h |  1 +
 3 files changed, 43 insertions(+), 11 deletions(-)

-- 
2.46.0


             reply	other threads:[~2024-09-18 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 10:44 David Gibson [this message]
2024-09-18 10:44 ` [PATCH v3 1/2] util: Add helper to write() all of a buffer David Gibson
2024-09-18 10:44 ` [PATCH v3 2/2] util: Remove possible quadratic behaviour from write_remainder() David Gibson
2024-09-19 10:42   ` Markus Armbruster
2024-09-19 15:36     ` David Gibson
2024-09-19 16:19     ` Stefano Brivio
2024-09-18 18:13 ` [PATCH v3 0/2] util: Fix some problems in write_remainder() Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240918104406.3050878-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=armbru@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).