From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y2B+luFO; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id D401D5A004C for ; Wed, 25 Sep 2024 19:39:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727285960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jl7qpYwwsIcMJFfIvC+EFVPqQW9GjS/uIixjr9HvHYw=; b=Y2B+luFO0J06cXCfCmmfyH1f1nnthtdnjZ5X+6JSEYNddtktF8UVmwsTYbNVossHET8htv WPUEfr4mRIQyMcYKwOGufit3xcl1vu03fNybT7nRRBM1eFoJfl2j+xjmbclRCHAo+f9oSL tTCRPYXxNcXaM01h91pRvdkeIuULxy8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-HeSj8uyeNcuORCNH-eLZ6A-1; Wed, 25 Sep 2024 13:39:19 -0400 X-MC-Unique: HeSj8uyeNcuORCNH-eLZ6A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cb479fab2so5451295e9.1 for ; Wed, 25 Sep 2024 10:39:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727285957; x=1727890757; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Jl7qpYwwsIcMJFfIvC+EFVPqQW9GjS/uIixjr9HvHYw=; b=j3ZNBIy2Tyo7XUXa+GkZBaoEJUvtKSmuYccWCfbFcwfsy6zmlAb04KbqiHc1IlNH1i oVxL8PBBoYspEmSFJRr4A8JnxSIVAKcQIm8CLS3oGmHDWng3+79t1nw5eh6myI3rK+xl FAgmJRxxjlinbvtxFrfkbRaIaJ/T72Luydf3cQY2dJ46e+J7lGGn9wp9LcniTbganSey e3fW2wO/cWF41uD+h85eWC5KDuzdSNzzVS7tcq2/sw4jCq2xjPtdQ+s+dFcTlNMX++84 Ifitvz9yhaZlfS1frMmwq1mFNyPe9PNAqTaoxBWeMsKd+kmwJD4C9cLat2EcF0QNwpvS hYSA== X-Gm-Message-State: AOJu0YyGokuvI1HA3BkWhOAv7LaM0Sce4kNMqLyU6OLnxdIU7vA77mA8 fPpSePz2fXExqj/grUxGoxcq5RBMd5etfawdRK8juhIWjP6KeznxtFj0A4S0nHYrDtOa51OdaYt VyfSHzo7tqtdGUJCkOo8GHDEInGKsvQ7DblU5OqRirwJt/XyF005Y5bSaUw== X-Received: by 2002:a05:600c:1992:b0:42c:b603:422 with SMTP id 5b1f17b1804b1-42f521d74aamr2686515e9.8.1727285957617; Wed, 25 Sep 2024 10:39:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNlHst01jRGPalBsHH766S4qt3R3lc3zTxToVqEXWKt4I3+teokqEpv5DsIeDwFkpEU4ADVg== X-Received: by 2002:a05:600c:1992:b0:42c:b603:422 with SMTP id 5b1f17b1804b1-42f521d74aamr2686395e9.8.1727285957189; Wed, 25 Sep 2024 10:39:17 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ccd6d7f49sm449355f8f.7.2024.09.25.10.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 10:39:16 -0700 (PDT) Date: Wed, 25 Sep 2024 19:39:15 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/4] Use inany addresses through port forwarding configuration Message-ID: <20240925193915.3defebab@elisabeth> In-Reply-To: <20240920041244.593192-1-david@gibson.dropbear.id.au> References: <20240920041244.593192-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GMESXMJEI2L7ZPUNK3I3FQQLPFVZPNWV X-Message-ID-Hash: GMESXMJEI2L7ZPUNK3I3FQQLPFVZPNWV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Sep 2024 14:12:40 +1000 David Gibson wrote: > We use inany addresses, which can represent either an IPv4 or IPv6 > address heavily through the flow table. However, for the > configuration of port forwarding: both the command line parsing and > initialization of listening sockets, we use address family+(void *) > pairs instead. > > Using inany through these paths makes them slightly neater now, but > more importantly will make it easier to add more robust tracking of > forwarding configuration. > > David Gibson (4): > udp: Don't attempt to get dual-stack sockets in nonsensical cases > util, pif: Replace sock_l4() with pif_sock_l4() > tcp, udp: Make {tcp,udp}_sock_init() take an inany address > inany: Add inany_pton() helper Applied, sorry for the delay. -- Stefano