public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, dgibson@redhat.com, lvivier@redhat.com
Subject: Re: Problematic throughput numbers
Date: Wed, 25 Sep 2024 19:47:58 +0200	[thread overview]
Message-ID: <20240925194758.242c7f5c@elisabeth> (raw)
In-Reply-To: <cb0a5320-12d7-4e0d-acee-2029b2fd89fa@redhat.com>

On Wed, 25 Sep 2024 12:36:43 -0400
Jon Maloy <jmaloy@redhat.com> wrote:

> I made many runs with iperf3 ns->host, and the results are puzzling me.

This has nothing to do with the path affected by your patches, because
you're connecting to a loopback address, and that's dealt with by
spliced connections. See tcp_splice.c, and:

  https://passt.top/#pasta-pack-a-subtle-tap-abstraction
  "Handling of local traffic in pasta" in pasta(1)

for more details. If you want to try out your patches, you could run
the test suite, or use a non-loopback address from the container.

> Over and over again, I see throughput practically collapse, with a two 
> orders of magnitude decrease.
> Just to make sure this wasn't something introduced by me, I went back to 
> the master branch and disabled the SO_PEEK_OFF feature.
> The result was the same.
> The below log shows typical run, but it is highly variable.
> Sometimes almost the whole series is in the 50-70 Gb/s range, and 
> sometimes almost all in the 100-300 Mb/s range.
> When I added the kernel fix it didn't seem to make any difference.
> 
> To me this is really worrying, and should be investigated.

I can't reproduce this, and we didn't have user reports of anything of
this sort, so far.

To investigate this, I would suggest that you have a look with strace
(as root) at what pasta is doing once the throughput decreases.

Packet captures with -p / --pcap won't show anything, because we don't
actually deal with packets on the spliced path.

Using --trace and a log file might help, but you'll probably decrease
throughput enough, that way, that the "good" condition won't be
distinguishable from the "bad" one.

-- 
Stefano


  reply	other threads:[~2024-09-25 17:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 16:36 Problematic throughput numbers Jon Maloy
2024-09-25 17:47 ` Stefano Brivio [this message]
2024-09-26  1:59 ` David Gibson
2024-09-26  3:45   ` Stefano Brivio
2024-09-26  3:50     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240925194758.242c7f5c@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=dgibson@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).