From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v4 4/5] tcp: Update TCP checksum using an iovec array
Date: Fri, 27 Sep 2024 08:22:19 +0200 [thread overview]
Message-ID: <20240927082219.1c3cc788@elisabeth> (raw)
In-Reply-To: <20240926140415.441208-5-lvivier@redhat.com>
On Thu, 26 Sep 2024 16:04:14 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> TCP header and payload are supposed to be in the same buffer,
> and tcp_update_check_tcp4()/tcp_update_check_tcp6() compute
> the checksum from the base address of the header using the
> length of the IP payload.
>
> In the future (for vhost-user) we need to dispatch the TCP header and
> the TCP payload through several buffers. To be able to manage that, we
> provide an iovec array that points to the data of the TCP frame.
> We provide also an offset to be able to provide an array that contains
> the TCP frame embedded in an lower level frame, and this offset points
> to the TCP header inside the iovec array.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
It looks like you missed David's comments from:
ZvS8wXSMfoexsqXr@zatzit.fritz.box
https://archives.passt.top/passt-dev/ZvS8wXSMfoexsqXr@zatzit.fritz.box/
Other than those, this looks good to me.
--
Stefano
next prev parent reply other threads:[~2024-09-27 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 14:04 [PATCH v4 0/5] tcp: use csum_iov() in tcp_update_check_tcp[4|6]() Laurent Vivier
2024-09-26 14:04 ` [PATCH v4 1/5] tcp: Use tcp_payload_t rather than tcphdr Laurent Vivier
2024-09-26 14:04 ` [PATCH v4 2/5] pcap: Add an offset argument in pcap_iov() Laurent Vivier
2024-09-26 14:04 ` [PATCH v4 3/5] checksum: Add an offset argument in csum_iov() Laurent Vivier
2024-09-26 14:04 ` [PATCH v4 4/5] tcp: Update TCP checksum using an iovec array Laurent Vivier
2024-09-27 6:22 ` Stefano Brivio [this message]
2024-09-26 14:04 ` [PATCH v4 5/5] udp: Update UDP " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240927082219.1c3cc788@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).