public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test: Kernel binary can now be passed via the KERNEL environmental variable
Date: Mon, 30 Sep 2024 10:39:05 +0200	[thread overview]
Message-ID: <20240930103905.1961613a@elisabeth> (raw)
In-Reply-To: <Zvjx6rTIkPpOGNF8@zatzit.fritz.box>

On Sun, 29 Sep 2024 16:21:30 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Fri, Sep 27, 2024 at 07:17:14PM +0200, Stefano Brivio wrote:
> > This is quite useful at least for myself as I'm usually running tests
> > using a guest kernel that's not the same as the one on the host.  
> 
> Hm.  I don't love doing this without also altering the mbuto.img
> creation to use the same kernel.

I rarely use the Makefile under test/ because I'm running these tests
mostly as ./ci, but yes, I was thinking about that as well.

On the other hand, mbuto needs a kernel version to figure out where the
kernel modules are, whereas the tests need a kernel binary, and I
didn't really have good ideas to take both into account without
introducing two variables in the Makefile which looks a bit clunky.

-- 
Stefano


      reply	other threads:[~2024-09-30  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 17:17 [PATCH] test: Kernel binary can now be passed via the KERNEL environmental variable Stefano Brivio
2024-09-29  6:21 ` David Gibson
2024-09-30  8:39   ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240930103905.1961613a@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).