public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/4] Don't expose container loopback services to the host
Date: Tue,  1 Oct 2024 16:24:58 +1000	[thread overview]
Message-ID: <20241001062502.1345449-1-david@gibson.dropbear.id.au> (raw)

podman issue #24045 pointed out that pasta's spliced forwarding logic
can expose services within the namespace bound only to 127.0.0.1 or
::1 to the host.  However, the namespace probably expects those to
only be accessible to itself, so that's probably not what we want.

This changes our forwarding logic so as not to do this.  Note that the
podman tests will currently fail with this series, I've submitted
podman PR https://github.com/containers/podman/pull/24064 to fix that.

Link: https://github.com/containers/podman/issues/24045

Changes since v1:
 * Add --host-lo-to-ns-lo option to preserve the old behaviour
 * Clarify the new behaviour in the man page
 * Add some extra patches making some other corrections to the man
   page

David Gibson (4):
  passt.1: Mark --stderr as deprecated more prominently
  passt.1: Clarify and update "Handling of local addresses" section
  test: Clarify test for spliced inbound transfers
  fwd: Direct inbound spliced forwards to the guest's external address

 conf.c               |  9 ++++++
 fwd.c                | 31 +++++++++++++-----
 passt.1              | 75 +++++++++++++++++++++++++++-----------------
 passt.h              |  1 +
 test/passt_in_ns/tcp |  8 ++---
 test/passt_in_ns/udp |  4 +--
 test/pasta/tcp       | 16 +++++-----
 test/pasta/udp       |  8 ++---
 8 files changed, 97 insertions(+), 55 deletions(-)

-- 
2.46.2


             reply	other threads:[~2024-10-01  6:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01  6:24 David Gibson [this message]
2024-10-01  6:24 ` [PATCH v2 1/4] passt.1: Mark --stderr as deprecated more prominently David Gibson
2024-10-01  6:25 ` [PATCH v2 2/4] passt.1: Clarify and update "Handling of local addresses" section David Gibson
2024-10-01  6:25 ` [PATCH v2 3/4] test: Clarify test for spliced inbound transfers David Gibson
2024-10-01  6:25 ` [PATCH v2 4/4] fwd: Direct inbound spliced forwards to the guest's external address David Gibson
2024-10-01 18:22   ` Stefano Brivio
2024-10-02  1:29     ` David Gibson
2024-10-02  5:32       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001062502.1345449-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).