Re: [PATCH v5 0/5] tcp: use csum_iov() in tcp_update_check_tcp[4|6]()

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 2 Oct 2024 16:32:38 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:

> On Fri, 27 Sep 2024 15:53:44 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
> > For vhost-user, we will need to spread TCP payload over
> > several buffers. To re-use tcp_update_check_tcp[4|6](),
> > provide an iovec rather than a pointer to a buffer.
> > 
> > This series updates also csum_iov() and pcap_iov() to
> > add an offset of bytes to skip in the iovec array.
> > 
> > It's based on top of "tcp: Use tcp_payload_t rather than tcphdr" that
> > is added in the series for convenience.
> > 
> > v3 adds "udp: Update UDP checksum using an iovec array" that modifies
> > csum_udp4() and csum_udp6() in the same way.
> > 
> > Laurent Vivier (5):
> >   tcp: Use tcp_payload_t rather than tcphdr
> >   pcap: Add an offset argument in pcap_iov()
> >   checksum: Add an offset argument in csum_iov()
> >   tcp: Update TCP checksum using an iovec array
> >   udp: Update UDP checksum using an iovec array  
> 
> I *think* something in this series causes two test failures.
> 
> I wasn't able to reproduce them without this series (tried five times),
> but I don't always reproduce them with it (tried about 10 times, I
> didn't get any failure for 3 runs, one or both in the other runs).
> 
> The first one looks like this (copy and paste to a buffer to see it):

Grr, never mind, this seem to be caused by "[PATCH v3 0/4] Don't expose
container loopback services to the host" or something that came before.

I'll now re-test a few times both series separately and report back.

-- 
Stefano