From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Xd3Don8J; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 30DB05A004E for ; Wed, 02 Oct 2024 16:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727880396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GAb/KjVARyaLfh9PTxXqug0RjYzG/s+wxtkIf7XZf9k=; b=Xd3Don8JdNIGmkwtw1/w7zsyM3tLREbRMH7h3PgD24u10lfAySB8ZDe7nnWio9Xb89t3Oz BwwCgq38CZ1f/ThUc0qPi4dqCjh+I6sAn9mXV5nzzU1LNdF3XUT8itQ9gh/yI5yaDrax/N PGApwxC3+HIHHPjNrINBCFAvJ0TbVR8= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-F9j2cXz-OdK6KTr0N-9oww-1; Wed, 02 Oct 2024 10:46:27 -0400 X-MC-Unique: F9j2cXz-OdK6KTr0N-9oww-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-7db8197d431so8970847a12.0 for ; Wed, 02 Oct 2024 07:46:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727880383; x=1728485183; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GAb/KjVARyaLfh9PTxXqug0RjYzG/s+wxtkIf7XZf9k=; b=E9ibPTcw/8VYlM/SxH6DaSal7zwKXCsjJAZ3fHQitzZtZSRymfLsSD3/0HeaJGBTPZ NhI5vMrLudCxyj/jMlGKchkILw1QeiCy3XhhLgs2yBtNN+z3FQFoRe/iuQCj75GDDD4t IW18CRxeS413Zd7oMTwPhyPlH+7kms4cFonzBhPZbuBgK4dw9JZhe7uidILBxGiqyQAY NdBSD/33C7waI2cYNHWS7z0WnY8IU+Pc1MZpqK7sDkOVxiiRPdy6nTEmMQ+7WBlhLCkO kRfozKHhXARZhN+zC3nWWho0QRC7dhYkJsKmmaEll2HnIXB4pgXXTcfTWLzBhIGc/ztM KHRQ== X-Gm-Message-State: AOJu0YwsT2pJxfFP6KaJA9n+TjyQDEnA3HTdUJakPKsmnaGOnILRhAp5 Ydta9OM+IyBREaCzInZeBOGFx5sIcqZQdziWQVnj2swwqc7h6JRgKac1htFmxZBgab9LG3GTRfQ ybNXJyexcmOs6umaUhg+ZLwB31fZbAQVWHkxQmqhv13cXeQIsOtzYgKu8r/PX0AZ/9eDA8RE6+Q Edol4APZb+oxAtjNM1wziGPKkDR4Ex2hPr X-Received: by 2002:a17:90b:4c8d:b0:2dd:4d3f:45ad with SMTP id 98e67ed59e1d1-2e1849e8da5mr4052710a91.38.1727880383122; Wed, 02 Oct 2024 07:46:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfmsdZeBQ56rEU2mH0yKZCAtff2M/43nZ1i17Rf2JgM3X7Jf9CnwQmAxv7+LS7DJuaumZEZg== X-Received: by 2002:a17:90b:4c8d:b0:2dd:4d3f:45ad with SMTP id 98e67ed59e1d1-2e1849e8da5mr4052690a91.38.1727880382671; Wed, 02 Oct 2024 07:46:22 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e18f776157sm1637709a91.17.2024.10.02.07.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 07:46:22 -0700 (PDT) Date: Wed, 2 Oct 2024 16:46:19 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v5 0/5] tcp: use csum_iov() in tcp_update_check_tcp[4|6]() Message-ID: <20241002164619.46e63900@elisabeth> In-Reply-To: <20241002163238.1778ed19@elisabeth> References: <20240927135349.675850-1-lvivier@redhat.com> <20241002163238.1778ed19@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZYYBT7T6DFSOONDLKCX6DJQMS2FGHGKI X-Message-ID-Hash: ZYYBT7T6DFSOONDLKCX6DJQMS2FGHGKI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 2 Oct 2024 16:32:38 +0200 Stefano Brivio wrote: > On Fri, 27 Sep 2024 15:53:44 +0200 > Laurent Vivier wrote: > > > For vhost-user, we will need to spread TCP payload over > > several buffers. To re-use tcp_update_check_tcp[4|6](), > > provide an iovec rather than a pointer to a buffer. > > > > This series updates also csum_iov() and pcap_iov() to > > add an offset of bytes to skip in the iovec array. > > > > It's based on top of "tcp: Use tcp_payload_t rather than tcphdr" that > > is added in the series for convenience. > > > > v3 adds "udp: Update UDP checksum using an iovec array" that modifies > > csum_udp4() and csum_udp6() in the same way. > > > > Laurent Vivier (5): > > tcp: Use tcp_payload_t rather than tcphdr > > pcap: Add an offset argument in pcap_iov() > > checksum: Add an offset argument in csum_iov() > > tcp: Update TCP checksum using an iovec array > > udp: Update UDP checksum using an iovec array > > I *think* something in this series causes two test failures. > > I wasn't able to reproduce them without this series (tried five times), > but I don't always reproduce them with it (tried about 10 times, I > didn't get any failure for 3 runs, one or both in the other runs). > > The first one looks like this (copy and paste to a buffer to see it): Grr, never mind, this seem to be caused by "[PATCH v3 0/4] Don't expose container loopback services to the host" or something that came before. I'll now re-test a few times both series separately and report back. -- Stefano