From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Uprrwsj0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id C98255A004E for ; Fri, 04 Oct 2024 15:11:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728047459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0r1SsiH/GoxSPWBSEHmymqj3s4JE0EgkQDsIPqP5EbY=; b=Uprrwsj01Y8+Fwr5g6J6uXOWFfVbJ95+5sh/YV5YGKqb4/6Hanf+aFtXPpIhiDHwz4X1Y/ NwGLm/ybcyjq1yEMXibrL/d9qb3bMZOV5stVG9xUFQ5fosQAoQQPFTqCc372ruETstMKz8 mT3/6TPRnVyQaJwRHIB2cicC/UayELU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-4SLOZATMMQi8Jc2pbrPuHg-1; Fri, 04 Oct 2024 09:10:58 -0400 X-MC-Unique: 4SLOZATMMQi8Jc2pbrPuHg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb9e14ab6so16208385e9.3 for ; Fri, 04 Oct 2024 06:10:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728047456; x=1728652256; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0r1SsiH/GoxSPWBSEHmymqj3s4JE0EgkQDsIPqP5EbY=; b=XqHH3suH2Hw7WkAGCWICwl8wsX/5ruqrWUufLEgt6MLKIp0afOMJWZ5h6iREHEDD+u rhOw1IyqX5OlYiRL7Hbeaj5wGMyRpr5B1HElDFPvHUpjW917lBzIR1IHcv0NKFHgmyWA SHzg3+KNKksndKWdsX36JgXc2uH44SqLROn+aut46TdUd80ejCuchVpJT3T3Kkepiv6M YMKbXNmODuwtaAtQtKnHZWfT/LFpiS92SVWUCdfMNo13Bj1uetE6mHuA2YerR9PRGH75 wKMcQ60Vpg+3eqd5rVwGe12tWeIVORbdrTJjhiS4gdB1IK+cnTX9AfuN42X2DssJvdUQ Dysw== X-Gm-Message-State: AOJu0YyCne1E1yulxoYeXHNPJn6n/CADxVAurfqqgt10JHXfohWX3GEH vypOSQ99vFCK2fYp3teRs+gsqbObWBSDxqgTdBbAg/6cOfRsvNKynYlJqi0sjM8oUfBXTe8x5E/ tZoQDZlO7Tf25qc2tPHzRNhAnN8f6e+E0HMes9HVQ6VF8wigBNOPPoqTZwLah6CqVeGZgfmfv5b CPkj4HoAhH2H0eKff8diIhObv1Z7gOeF8d X-Received: by 2002:a05:600c:4e0e:b0:42c:cd7c:a196 with SMTP id 5b1f17b1804b1-42f85ab8e82mr22926205e9.17.1728047455912; Fri, 04 Oct 2024 06:10:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyDYPJCrQYTlVYx49zPozJVU+ci1uTmGW4JohmgZjE2dPXfYQl9WbDAliwsJg1pgThlsqizQ== X-Received: by 2002:a05:600c:4e0e:b0:42c:cd7c:a196 with SMTP id 5b1f17b1804b1-42f85ab8e82mr22925835e9.17.1728047455396; Fri, 04 Oct 2024 06:10:55 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f85995932sm15031195e9.0.2024.10.04.06.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 06:10:54 -0700 (PDT) Date: Fri, 4 Oct 2024 15:10:53 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v6 0/5] tcp: use csum_iov() in tcp_update_check_tcp[4|6]() Message-ID: <20241004151053.3e76478d@elisabeth> In-Reply-To: <20241003145108.2227355-1-lvivier@redhat.com> References: <20241003145108.2227355-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KQLLT3B7RMNIRKHAGGARVLTF7O4QGQDK X-Message-ID-Hash: KQLLT3B7RMNIRKHAGGARVLTF7O4QGQDK X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 3 Oct 2024 16:51:03 +0200 Laurent Vivier wrote: > For vhost-user, we will need to spread TCP payload over > several buffers. To re-use tcp_update_check_tcp[4|6](), > provide an iovec rather than a pointer to a buffer. > > This series updates also csum_iov() and pcap_iov() to > add an offset of bytes to skip in the iovec array. > > It's based on top of "tcp: Use tcp_payload_t rather than tcphdr" that > is added in the series for convenience. > > v6: update tcp.c with fix for clang-tidy error and add missing static > > Laurent Vivier (5): > tcp: Use tcp_payload_t rather than tcphdr > pcap: Add an offset argument in pcap_iov() > checksum: Add an offset argument in csum_iov() > tcp: Update TCP checksum using an iovec array > udp: Update UDP checksum using an iovec array I ran tests a few times with just this series, no failures observed. Applied, sorry for the delay. -- Stefano