From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IVVbLAKo; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id DC4505A004C for ; Mon, 07 Oct 2024 16:30:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728311407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XiWTapek4DSil2lVv5/X2Pm6w2EqryW2xXgOJxEUfqs=; b=IVVbLAKo9Y9hiCKYMSenMF3Dc1oGPeIBSt6nTmeH81sde6zYt3ASa+UH/yTsXhLCnT7n6C a+8yYWs8TwSfXkMykFPc/LfuF2ViABEXsZ4INy5jnV5hIQh9JcOJscntchPPcZHuRB14HY 9CoG6oG/0/zTSa28XVHzzb9E98edyyU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-g3E2JLsrNSmGbi-AzPQ5Sg-1; Mon, 07 Oct 2024 10:30:06 -0400 X-MC-Unique: g3E2JLsrNSmGbi-AzPQ5Sg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37cd1fb9497so2731760f8f.1 for ; Mon, 07 Oct 2024 07:30:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728311404; x=1728916204; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XiWTapek4DSil2lVv5/X2Pm6w2EqryW2xXgOJxEUfqs=; b=nNPhqfqJSI5KZjcPjy/gYd1CP/+6yhwSoEAAkgUvYhkudET+FBLNEvJsKrEfG8QuBm CGbJSkmFpvijAiNiSr+6yN/201JfYlT/SHevkA3kXhKLMVlh4gYNu+IiPmPPKlkTMZdI nwdQudWfs7gJjkt5fY+dqTOgUHxDO708RfPwEifZ84V8m152exBhjFwq+Xwt9n60Hdec nOE7zNjGdvKztVlf/7ertl9SWuCBL2vbjmM6bg4rv7aKtFFnveUtF265+o/kd7z8K5Dy uompUEKVW1iyn6lALiiNL+VGsg45eSJhSlF8B4N8CoHYu6iZK1C5WGjVy5ThpUPfo+Dn otIQ== X-Gm-Message-State: AOJu0YyrQaPS9+V4AQ7fe4cp7HYZIs3DbnGIcjKiyeZlsQe0ZeuT1vV5 0dr+hJOfknWR/poOI6wfTpTrNbZYktfD7tgrPqVf/ECYh06n2Uiiz+xTRADXPhw5i0FCW+tCPJK 8gh5Wi5kaPyESZ8G6FxLEVk2OQEYymSqANwOmQMiiT9gB8OV3TGKOJ0m2b4z1G7d9GARVJDX4FH POZCwPW6ajaL9RkxjFtPJVDA5P+9osSF3D X-Received: by 2002:adf:978a:0:b0:371:6fc7:d45d with SMTP id ffacd0b85a97d-37d0f66e0c0mr6473663f8f.2.1728311404214; Mon, 07 Oct 2024 07:30:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFpy3Gkp1TuAHRkjHdb0svppWvmECDVMXsrPeTUFA8tPR0ry21440rv04B2jqYfQuyhm092Q== X-Received: by 2002:adf:978a:0:b0:371:6fc7:d45d with SMTP id ffacd0b85a97d-37d0f66e0c0mr6473644f8f.2.1728311403707; Mon, 07 Oct 2024 07:30:03 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d1696ff1asm5825250f8f.94.2024.10.07.07.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 07:30:02 -0700 (PDT) Date: Mon, 7 Oct 2024 16:30:00 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v2] test: Add tests for passt in vhost-user mode Message-ID: <20241007163000.039276dc@elisabeth> In-Reply-To: <6a4e01c7-4fc7-4c5a-85d9-7b74b255cff6@redhat.com> References: <20241001182228.2347208-1-sbrivio@redhat.com> <6a4e01c7-4fc7-4c5a-85d9-7b74b255cff6@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: K4J4KBQK4SOBGKVGKFJXYDQHRHIIUC3W X-Message-ID-Hash: K4J4KBQK4SOBGKVGKFJXYDQHRHIIUC3W X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 7 Oct 2024 13:57:39 +0200 Laurent Vivier wrote: > On 01/10/2024 20:22, Stefano Brivio wrote: > > Run functional and performance tests for vhost-user mode as well. For > > functional tests, we add passt_vu and passt_vu_in_ns as symbolic links > > to their non-vhost-user counterparts, as no differences are intended > > but we want to distinguish them in test logs. > > > > For performance tests, instead, we add separate perf/passt_vu_tcp and > > perf/passt_vu_udp files, as we need longer test duration, as well as > > higher UDP sending bandwidths and larger TCP windows, to actually get > > the highest throughput vhost-user mode offers. > > > > For valgrind tests, vhost-user mode needs two extra system calls: > > statx and readlink. Add them as EXTRA_SYSCALLS for the valgrind > > target. > > > > Signed-off-by: Stefano Brivio > > --- > > v2: > > - oops, add all the files I forgot in v1: test/perf/passt_vu_tcp, > > test/perf/passt_vu_udp, and symbolic links > > - also run the 'two_guests' case in vhost-user mode > > > > Makefile | 3 +- > > test/lib/perf_report | 15 +++ > > test/lib/setup | 77 ++++++++++++--- > > test/passt_vu | 1 + > > test/passt_vu_in_ns | 1 + > > test/perf/passt_vu_tcp | 211 +++++++++++++++++++++++++++++++++++++++++ > > test/perf/passt_vu_udp | 159 +++++++++++++++++++++++++++++++ > > test/run | 25 +++++ > > test/two_guests_vu | 1 + > > 9 files changed, 478 insertions(+), 15 deletions(-) > > create mode 120000 test/passt_vu > > create mode 120000 test/passt_vu_in_ns > > create mode 100644 test/perf/passt_vu_tcp > > create mode 100644 test/perf/passt_vu_udp > > create mode 120000 test/two_guests_vu > > > > Something like this is missing: > > diff --git a/test/lib/setup_ugly b/test/lib/setup_ugly > index 4b2a0774de1d..46089eb9834b 100755 > --- a/test/lib/setup_ugly > +++ b/test/lib/setup_ugly > @@ -33,7 +33,7 @@ setup_memory() { > > pane_or_context_run guest 'qemu-system-$(uname -m)' \ > ' -machine accel=kvm' \ > - ' -m '${VMEM}' -cpu host -smp '${VCPUS} \ > + ' -m '$((${MEM_KIB} / 1024 / 4))' -cpu host -smp '${VCPUS} \ Oops, right, I guess I skipped that test as well while testing this change. Feel free to just change that in this patch if you carry it in your series (it looks okay to me). -- Stefano