From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UNO/OjvT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 6692F5A004E for ; Wed, 16 Oct 2024 11:47:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729072055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YzcB2EwSU+kWa3mzVeFkS56glLnxfUUFkcAF2RnNGSw=; b=UNO/OjvTxTZHXTAndX6ZFUAT63S5kaUfh1Tspf3/6PpvtTjki88ohqVdfHQHLd8NSg1gCj uPUHgis/7Pri22YT+dh7ma4geQds8aaROMY18XdoDFWnJ4lrbYEIPT+28xVG3gwnVzinBv c2vnhIcax77mJ6r1jMxWLVI1pjPt6Zk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-IwDYUwLsM--v2jHvdDZ1Mg-1; Wed, 16 Oct 2024 05:47:34 -0400 X-MC-Unique: IwDYUwLsM--v2jHvdDZ1Mg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4315544642eso438435e9.3 for ; Wed, 16 Oct 2024 02:47:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729072052; x=1729676852; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YzcB2EwSU+kWa3mzVeFkS56glLnxfUUFkcAF2RnNGSw=; b=U86Lt71qf75yLJY1d3C8IjMtIiWU4t5Kg3uFHStRp8rL3NqKqG/4ZqreMoqz1U/ZeV GdJlon1R1O7qzaeyGYZ/LcYoFGMzbwHQ0xKVk1eM3JJBAto2y+NhuRm+hLxc+YD5bk2x gOpeODZbQe4TRejKCmrqEkcULBjn1SGL+asg1to3jirA7N04zaP305vies0Nzw+HOv1b cXqRwTuVstG+5OagF0x07EU503k5A09Drwy+mGLyMKOo2WRouamlf5R/5hykzBE2qJii 51kYcWvMn2vObBH3aSKJAoR7oU+hCSGVOxHGp2GTWXArXGbBNdqabhHcrjQd+zcgOe1F SVLg== X-Gm-Message-State: AOJu0YxoiMCocCx+d+fdwlmuXQdomLTiw1FU3xTQVH5ZaQYqPIhuo6qq DBrFLQ+PPgz1KjCPxN9bINyTDw5NQBMrNOSFfkgeZFJIlj3ICkb+Tz8wKbGzPoDaePc+avkKnFh ol8maxCwYY9HAT8Cva+GkQXPyFUawK2kU/HAC0nM60Xu5rFxLju4CiVjLQCp9PljS6MjZKHs+8W qJK4h6U+JghRRnidAj0ssYANVsWAxYW49q X-Received: by 2002:a05:600c:3588:b0:42c:b905:2c04 with SMTP id 5b1f17b1804b1-4311ded19c1mr149864995e9.12.1729072051745; Wed, 16 Oct 2024 02:47:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxv5zGyOZuu7woiIg1KGQ7Fr/1YWgDkTJBiwB8yA0rFqk0T7ln8B/+sy1mBSO0HxY27ER4oQ== X-Received: by 2002:a05:600c:3588:b0:42c:b905:2c04 with SMTP id 5b1f17b1804b1-4311ded19c1mr149864775e9.12.1729072051131; Wed, 16 Oct 2024 02:47:31 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4313f55dff7sm44257415e9.7.2024.10.16.02.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 02:47:29 -0700 (PDT) Date: Wed, 16 Oct 2024 11:47:28 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v8 8/8] test: Add tests for passt in vhost-user mode Message-ID: <20241016114728.6ea430f8@elisabeth> In-Reply-To: <10fc67af-4950-44b3-b0a5-a7a5d1e209a0@redhat.com> References: <20241010122903.1188992-1-lvivier@redhat.com> <20241010122903.1188992-9-lvivier@redhat.com> <20241015215422.6d4124c6@elisabeth> <10fc67af-4950-44b3-b0a5-a7a5d1e209a0@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 23N2ODFSDBEDN2T7NCSJO45DJV5CR6S2 X-Message-ID-Hash: 23N2ODFSDBEDN2T7NCSJO45DJV5CR6S2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 16 Oct 2024 10:06:21 +0200 Laurent Vivier wrote: > On 15/10/2024 21:54, Stefano Brivio wrote: > > On Thu, 10 Oct 2024 14:29:02 +0200 > > Laurent Vivier wrote: > > > >> From: Stefano Brivio > >> > >> Run functional and performance tests for vhost-user mode as well. For > >> functional tests, we add passt_vu and passt_vu_in_ns as symbolic links > >> to their non-vhost-user counterparts, as no differences are intended > >> but we want to distinguish them in test logs. > >> > >> [...] > >> > >> diff --git a/test/two_guests_vu b/test/two_guests_vu > >> new file mode 120000 > >> index 000000000000..144b7cac5438 > >> --- /dev/null > >> +++ b/test/two_guests_vu > >> @@ -0,0 +1 @@ > >> +test/two_guests > >> \ No newline at end of file > > > > Oops, this link is wrong: it works if you execute the tests from the > > top git directory, but not if you run them from test/. It should simply > > point to 'two_guests', not to 'test/two_guests'. > > > > For some reason, even with that fixed, v8 fails for me on that test: > > 'dhclient -6 eth0' gets stuck in guest #2 (it works in guest #1). I > > still need to debug that. I'm fairly sure that v6 or v7 worked. > > Perhaps because of this: > > diff --git a/test/lib/setup b/test/lib/setup > index 3409bd29cd81..580825f1f9a7 100755 > --- a/test/lib/setup > +++ b/test/lib/setup > @@ -264,7 +264,7 @@ setup_two_guests() { > -device virtio-net,netdev=v \ > -object memory-backend-memfd,id=m,share=on,size=${__vmem} \ > -numa node,memdev=m" > - __qemu_netdev1=" \ > + __qemu_netdev2=" \ > -chardev socket,id=c,path=${STATESETUP}/passt_2.socket \ > -netdev vhost-user,id=v,chardev=c \ > -device virtio-net,netdev=v \ Oops, right, nice catch. All tests pass for me now. It was broken already in the first version I sent, I wonder how it ever worked for me... I guess I had some local changes on top. -- Stefano