public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v5 0/7] Don't expose container loopback services to the host
Date: Fri, 18 Oct 2024 21:06:07 +0200	[thread overview]
Message-ID: <20241018210607.510399a4@elisabeth> (raw)
In-Reply-To: <20241018013556.1266295-1-david@gibson.dropbear.id.au>

On Fri, 18 Oct 2024 12:35:49 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> podman issue #24045 pointed out that pasta's spliced forwarding logic
> can expose services within the namespace bound only to 127.0.0.1 or
> ::1 to the host.  However, the namespace probably expects those to
> only be accessible to itself, so that's probably not what we want.
> 
> This changes our forwarding logic so as not to do this.  Note that the
> podman tests will currently fail with this series, I've submitted
> podman PR https://github.com/containers/podman/pull/24064 to fix that.
> 
> Link: https://github.com/containers/podman/issues/24045
> 
> Changes since v4:
>  * Handled a few cases where we need to wait for DAD which were missed
>    in v4.
>  * Fix a grammar error in comment
> Changes since v3:
>  * Added several extra patches working around failures on Debian,
>    because its dhclient-script doesn't wait for DAD to complete
> Changes since v2:
>  * Add new field do structure comment
> Changes since v1:
>  * Add --host-lo-to-ns-lo option to preserve the old behaviour
>  * Clarify the new behaviour in the man page
>  * Add some extra patches making some other corrections to the man
>    page
> 
> David Gibson (7):
>   arp: Fix a handful of small warts
>   test: Explicitly wait for DAD to complete on SLAAC addresses
>   test: Wait for DAD on DHCPv6 addresses
>   passt.1: Mark --stderr as deprecated more prominently
>   passt.1: Clarify and update "Handling of local addresses" section
>   test: Clarify test for spliced inbound transfers
>   fwd: Direct inbound spliced forwards to the guest's external address

Applied.

-- 
Stefano


      parent reply	other threads:[~2024-10-18 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18  1:35 [PATCH v5 0/7] Don't expose container loopback services to the host David Gibson
2024-10-18  1:35 ` [PATCH v5 1/7] arp: Fix a handful of small warts David Gibson
2024-10-18  1:35 ` [PATCH v5 2/7] test: Explicitly wait for DAD to complete on SLAAC addresses David Gibson
2024-10-18  1:35 ` [PATCH v5 3/7] test: Wait for DAD on DHCPv6 addresses David Gibson
2024-10-18  1:35 ` [PATCH v5 4/7] passt.1: Mark --stderr as deprecated more prominently David Gibson
2024-10-18  1:35 ` [PATCH v5 5/7] passt.1: Clarify and update "Handling of local addresses" section David Gibson
2024-10-18  1:35 ` [PATCH v5 6/7] test: Clarify test for spliced inbound transfers David Gibson
2024-10-18  1:35 ` [PATCH v5 7/7] fwd: Direct inbound spliced forwards to the guest's external address David Gibson
2024-10-18 19:06 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018210607.510399a4@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).