From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tcp: Use structures to construct initial TCP options
Date: Mon, 21 Oct 2024 20:11:29 +0200 [thread overview]
Message-ID: <20241021201129.6291b2d2@elisabeth> (raw)
In-Reply-To: <20241021074029.2271142-1-david@gibson.dropbear.id.au>
On Mon, 21 Oct 2024 18:40:29 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> As a rule, we prefer constructing packets with matching C structures,
> rather than building them byte by byte. However, one case we still build
> byte by byte is the TCP options we include in SYN packets (in fact the only
> time we generate TCP options on the tap interface).
>
> Rework this to use a structure and initialisers which make it a bit
> clearer what's going on.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
By the way, since you were wondering: I originally added the NOP option
before the MSS option simply because the Linux kernel does that as
well: typically, "SACK Permitted" and "Timestamps" (12 bytes
altogether, hence aligned) come first, then NOP, then MSS.
--
Stefano
prev parent reply other threads:[~2024-10-21 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 7:40 [PATCH] tcp: Use structures to construct initial TCP options David Gibson
2024-10-21 18:11 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021201129.6291b2d2@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).