From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MeeXV7FT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 2D3C95A004C for ; Mon, 21 Oct 2024 20:51:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729536694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ol8OdtpTCZ+jdPxTpUixPpjlQetT0koYuLlkDzyUS+Y=; b=MeeXV7FTYS4vPNKyHQoKLpW7aKYOfBuqjUVZDpGiJhBdIXUYegCPf3jJ1O8BQ6C/8pbWRY vvSw/oEJV+K97kjEYotknWyuPX3QaqMrvWg+aOYHigMQ1rTux5zPVDDdDYKotMg2rAgVU3 zGzNkkXdzUDmPwMISh1jr2APtrCB4Fs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-ZY3ne8gTMZmlq2dXfY8z0w-1; Mon, 21 Oct 2024 14:51:33 -0400 X-MC-Unique: ZY3ne8gTMZmlq2dXfY8z0w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4316e350d6aso14157235e9.3 for ; Mon, 21 Oct 2024 11:51:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729536689; x=1730141489; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ol8OdtpTCZ+jdPxTpUixPpjlQetT0koYuLlkDzyUS+Y=; b=MuwVgCqQjZsblg3GfXlqB6ucgZcgeewZnKkUtyQzMNViQCKFn8tuSCsdaeg3m3BPE9 WP5HJS93cBHqZqfTzg7hYkK1ukbd7/1pzA8GIX/hkFJb8qM4SzqYB1pMyc4UzS9MsfwQ +l4kSNAEcRymXH8JRprc260rdyWwOuhVQ2pKPcMkZYDH9imSe9hwS5Lqe5e2pWKaEH+N t91sQnC/F6f6OCwQ1rqic2PZ7Pos0NZ6saIYTa+FezB3VkZh9tDkXwGuI1YRS3u200+K ptC7eHTq9rqTbTYXtGQHbB1EqR9vhyE6BX/4/nzXyriEZPNYOMN+F/W/amVmJyO61A1+ gaEQ== X-Gm-Message-State: AOJu0YzELkuCQbyHQdLZdWH4BJ+YopoInIX4Ph5Gm6z+daKoSgKE0lDi 5tRvtRLrdAfps2EdTBnB4aScF9LxRQdlesOVFSa9HhkChnyqvMCkGGD8pJqQi59yzuoMfJ4kea7 rzfsVanExMXxgtW4SQYPL3EsgxXdsvZbiRf+PfvggYT9KAtudO8UUvNrZ5yFkKYisx380lz72yp d50bxMLkuAtdjcnPXcQavqfLIJyrnfVhtn X-Received: by 2002:a05:600c:5124:b0:42f:823d:dddd with SMTP id 5b1f17b1804b1-4316169a57amr87307165e9.27.1729536689322; Mon, 21 Oct 2024 11:51:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPuDbrBv+J4+yBECOWY1csaeUSttS6WemE7wOsdrl8b00yOuKcXmCKQPvbOvfk73cUg4CECA== X-Received: by 2002:a05:600c:5124:b0:42f:823d:dddd with SMTP id 5b1f17b1804b1-4316169a57amr87306925e9.27.1729536688844; Mon, 21 Oct 2024 11:51:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f50b15csm65777945e9.0.2024.10.21.11.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 11:51:27 -0700 (PDT) Date: Mon, 21 Oct 2024 20:51:26 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v4 0/2] tcp: unify IPv4 and IPv6 tap queues Message-ID: <20241021205126.275cfa14@elisabeth> In-Reply-To: <20241011183540.3045143-1-jmaloy@redhat.com> References: <20241011183540.3045143-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6P3JHI66BXIRMSEIRUXQZJYHDN4632YR X-Message-ID-Hash: 6P3JHI66BXIRMSEIRUXQZJYHDN4632YR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 11 Oct 2024 14:35:38 -0400 Jon Maloy wrote: > This should save us some memory and code. > > --- > v2: - Setting pointers to pre-set IP and MAC headers on the fly > instead of copying them. > - Merged patch #2 and #3 from v1 > v3: - Changes based on feedback from team > v4: - Rebased to latest version of master branch > > Jon Maloy (2): > tcp: set ip and eth headers in l2 tap queues on the fly > tcp: unify l2 TCPv4 and TCPv6 queues and structures Tests pass for me now, and, minus the pending comments from David, the series looks good to me. -- Stefano