public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/2] tcp: Runtime checks for availability of TCP_INFO fields
Date: Wed, 23 Oct 2024 11:42:51 +1100	[thread overview]
Message-ID: <20241023004253.1729124-1-david@gibson.dropbear.id.au> (raw)

We have a number of Makefile tests for the presence of various fields
in tcp_info.  However that only tells us if they're present in the
kernel headers against which we're compiling, not whether they're
available in the kernel we're running on.  For anything outside the
earliest forms of TCP_INFO (as described in netinet/tcp.h and shared
with BSD), we should verify at runtime if the kernel is returning that
information.

This was supposed to be leading into improved handling of lazily
calling TCP_INFO, but I hit additional complications there, so I've
postponed it.  Might as well get these bits merged, though.

David Gibson (2):
  tcp: Generalise probing for tcpi_snd_wnd field
  tcp: Use runtime tests for TCP_INFO fields

 tcp.c | 97 +++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 57 insertions(+), 40 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-10-23  0:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  0:42 David Gibson [this message]
2024-10-23  0:42 ` [PATCH 1/2] tcp: Generalise probing for tcpi_snd_wnd field David Gibson
2024-10-23  0:42 ` [PATCH 2/2] tcp: Use runtime tests for TCP_INFO fields David Gibson
2024-10-23  7:41   ` Stefano Brivio
2024-10-24  2:02     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023004253.1729124-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).