From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH] tcp_splice: fcntl(2) returns the size of the pipe, if F_SETPIPE_SZ succeeds
Date: Fri, 25 Oct 2024 09:52:55 +0200 [thread overview]
Message-ID: <20241025095255.10430732@elisabeth> (raw)
In-Reply-To: <Zxrkpy7HEOWXiyJ3@zatzit>
On Fri, 25 Oct 2024 11:21:59 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Fri, Oct 25, 2024 at 01:04:18AM +0200, Stefano Brivio wrote:
> > Don't report bogus failures (with --trace) just because the return
> > value is not zero.
> >
> > Link: https://github.com/containers/podman/issues/24219
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
>
> I think this is technicall still not quite right, because F_SETPIPE_SZ
> can return a value larger than the one requested.
Right, that might happen, but I also thought that that would be
interesting enough for us to print, especially because we first probe
for a size that we can set at least for one pool of pipes.
If we get a bigger size than what we wanted to set, it's somewhat more
likely that we'd have issues setting the same size for other pipes.
--
Stefano
prev parent reply other threads:[~2024-10-25 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 23:04 [PATCH] tcp_splice: fcntl(2) returns the size of the pipe, if F_SETPIPE_SZ succeeds Stefano Brivio
2024-10-25 0:21 ` David Gibson
2024-10-25 7:52 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025095255.10430732@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).