From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XeVdr+NX; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 863015A004C for ; Fri, 25 Oct 2024 09:53:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729842787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvHGoWoQDuKT1bEQ6Xj7OY/gFATmsiQ/n7smII+QS3g=; b=XeVdr+NX62OVZ9fydt4rJgEL9sKcSudv9q6NYMMScBSBM7XSQEo6U9nTV55s/36oYqX7Nn jqGDf6WuMwVxQjQhNU5xdRWdSGUnE1sWcwNPwtKGTFnxw+ZlO9Snbg+eXqU8UxCahMPaf1 VH4AAdTzFC50HI1dTnT2/281xe/uBds= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-B7LZwRPdOyusvTZjtDmcYA-1; Fri, 25 Oct 2024 03:53:06 -0400 X-MC-Unique: B7LZwRPdOyusvTZjtDmcYA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-20ca0a58524so20828735ad.1 for ; Fri, 25 Oct 2024 00:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729842785; x=1730447585; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uvHGoWoQDuKT1bEQ6Xj7OY/gFATmsiQ/n7smII+QS3g=; b=YdzGGWMYk8D9qLvKBGQ1sOjsfaPGKJB1x7ktyUx4M0CvuQlj+HbhxdaG3XwYkp1FhU rKmaanXJD7u69RPQIc7P87hBwd9yFPz7XoIXo90bX2KIKJ79yJybnHGj62QmcMagexob ggoJNUXakSLhoJWsDfc0OJRjmkQNX2642DtMCan6gmeOcuK96HTtpY32c5d1pproy8Eh F6COOrKERellmvU7Xz1iU63m5Hq0gO7uOuYwp+LtNmwJUhDxLaxOEEP9ID0FQiAzuw2b 4YSlef54V8VogUbaG8uEEkPnO9h9MIZMSijjCeVKTWQZGTvueuicp0uxJ8EJChKPAEzo zaGw== X-Gm-Message-State: AOJu0YzTQIqcHgJTASad/gy/Hofc5tUA0BuPQXJvs2LFbGDQFsoonHcx 4mmLrTG6/r1cELU8qlKDcCHfFQgQu3Hf3aCP7J8h9o0OZ786NPsCJiGrIkJkexxFCSFaNyN8TLv KYiszZnZKqq53o2Dmx13W40q4aQA4zXCUcvGXW8ffOmBKlaS05w== X-Received: by 2002:a17:902:ec82:b0:20c:8c0f:f986 with SMTP id d9443c01a7336-20fa9e5b449mr121897755ad.24.1729842784981; Fri, 25 Oct 2024 00:53:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE/0oRHf14BDL0laNBK/Jk6zZne/L06BV/3r89c2jDYMDE1A+of8enb8csVojaKj2PZ7AFnw== X-Received: by 2002:a17:902:ec82:b0:20c:8c0f:f986 with SMTP id d9443c01a7336-20fa9e5b449mr121897645ad.24.1729842784645; Fri, 25 Oct 2024 00:53:04 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02dba9sm4845915ad.188.2024.10.25.00.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 00:53:02 -0700 (PDT) Date: Fri, 25 Oct 2024 09:52:55 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] tcp_splice: fcntl(2) returns the size of the pipe, if F_SETPIPE_SZ succeeds Message-ID: <20241025095255.10430732@elisabeth> In-Reply-To: References: <20241024230418.3192524-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SUA64IARKRP5QPSTRSTRTDTXIN27V77L X-Message-ID-Hash: SUA64IARKRP5QPSTRSTRTDTXIN27V77L X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 25 Oct 2024 11:21:59 +1100 David Gibson wrote: > On Fri, Oct 25, 2024 at 01:04:18AM +0200, Stefano Brivio wrote: > > Don't report bogus failures (with --trace) just because the return > > value is not zero. > > > > Link: https://github.com/containers/podman/issues/24219 > > Signed-off-by: Stefano Brivio > > I think this is technicall still not quite right, because F_SETPIPE_SZ > can return a value larger than the one requested. Right, that might happen, but I also thought that that would be interesting enough for us to print, especially because we first probe for a size that we can set at least for one pool of pipes. If we get a bigger size than what we wanted to set, it's somewhat more likely that we'd have issues setting the same size for other pipes. -- Stefano