public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 5/8] treewide: Suppress clang-tidy warning if we already use O_CLOEXEC or if we can't
Date: Fri, 25 Oct 2024 14:08:11 +0200	[thread overview]
Message-ID: <20241025120814.3449347-6-sbrivio@redhat.com> (raw)
In-Reply-To: <20241025120814.3449347-1-sbrivio@redhat.com>

In pcap_init(), we open the packet capture file with O_CLOEXEC only
when possible.

In logfile_init() and pidfile_open(), the fact that we pass a third
'mode' argument to open() seems to confuse the android-cloexec-open
checker in LLVM versions from 16 to 19 (at least).

The checker is suggesting to add O_CLOEXEC to 'mode', and not in
'flags', where we already have it.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 log.c  | 4 ++++
 pcap.c | 1 +
 util.c | 4 ++++
 3 files changed, 9 insertions(+)

diff --git a/log.c b/log.c
index 6932885..154466f 100644
--- a/log.c
+++ b/log.c
@@ -416,7 +416,11 @@ void logfile_init(const char *name, const char *path, size_t size)
 	if (readlink("/proc/self/exe", exe, PATH_MAX - 1) < 0)
 		die_perror("Failed to read own /proc/self/exe link");
 
+	/* We use O_CLOEXEC here, but clang-tidy as of LLVM 16 to 19 looks for
+	 * it in the 'mode' argument if we have one, so...
+	 */
 	log_file = open(path, O_CREAT | O_TRUNC | O_APPEND | O_RDWR | O_CLOEXEC,
+			/* NOLINTNEXTLINE(android-cloexec-open) */
 			S_IRUSR | S_IWUSR);
 	if (log_file == -1)
 		die_perror("Couldn't open log file %s", path);
diff --git a/pcap.c b/pcap.c
index 6ee6cdf..6753cfb 100644
--- a/pcap.c
+++ b/pcap.c
@@ -167,6 +167,7 @@ void pcap_init(struct ctx *c)
 		return;
 
 	flags |= c->foreground ? O_CLOEXEC : 0;
+	/* NOLINTNEXTLINE(android-cloexec-open): ...only where possible */
 	pcap_fd = open(c->pcap, flags, S_IRUSR | S_IWUSR);
 	if (pcap_fd == -1) {
 		perror("open");
diff --git a/util.c b/util.c
index 9cb705e..75aee81 100644
--- a/util.c
+++ b/util.c
@@ -419,7 +419,11 @@ int pidfile_open(const char *path)
 	if (!*path)
 		return -1;
 
+	/* We use O_CLOEXEC here, but clang-tidy as of LLVM 16 to 19 looks for
+	 * it in the 'mode' argument if we have one
+	 */
 	if ((fd = open(path, O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
+			     /* NOLINTNEXTLINE(android-cloexec-open) */
 			     S_IRUSR | S_IWUSR)) < 0) {
 		perror("PID file open");
 		exit(EXIT_FAILURE);
-- 
@@ -419,7 +419,11 @@ int pidfile_open(const char *path)
 	if (!*path)
 		return -1;
 
+	/* We use O_CLOEXEC here, but clang-tidy as of LLVM 16 to 19 looks for
+	 * it in the 'mode' argument if we have one
+	 */
 	if ((fd = open(path, O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
+			     /* NOLINTNEXTLINE(android-cloexec-open) */
 			     S_IRUSR | S_IWUSR)) < 0) {
 		perror("PID file open");
 		exit(EXIT_FAILURE);
-- 
2.43.0


  parent reply	other threads:[~2024-10-25 12:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 12:08 [PATCH v2 0/8] Take care of clang-tidy warnings with LLVM >= 16 Stefano Brivio
2024-10-25 12:08 ` [PATCH v2 1/8] Makefile: Exclude qrap.c from clang-tidy checks Stefano Brivio
2024-10-25 12:08 ` [PATCH v2 2/8] treewide: Comply with CERT C rule ERR33-C for snprintf() Stefano Brivio
2024-10-28  0:58   ` David Gibson
2024-10-25 12:08 ` [PATCH v2 3/8] treewide: Silence cert-err33-c clang-tidy warnings for fprintf() Stefano Brivio
2024-10-25 12:08 ` [PATCH v2 4/8] Makefile: Disable readability-math-missing-parentheses clang-tidy check Stefano Brivio
2024-10-25 12:08 ` Stefano Brivio [this message]
2024-10-28  1:00   ` [PATCH v2 5/8] treewide: Suppress clang-tidy warning if we already use O_CLOEXEC or if we can't David Gibson
2024-10-28  9:04     ` Stefano Brivio
2024-10-25 12:08 ` [PATCH v2 6/8] treewide: Address cert-err33-c clang-tidy warnings for clock and timer functions Stefano Brivio
2024-10-28  1:01   ` David Gibson
2024-10-25 12:08 ` [PATCH v2 7/8] udp: Take care of cert-int09-c clang-tidy warning for enum udp_iov_idx Stefano Brivio
2024-10-28  1:02   ` David Gibson
2024-10-25 12:08 ` [PATCH v2 8/8] util: Don't use errno after a successful call in __daemon() Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025120814.3449347-6-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).