From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=g4XmfC1x; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 2A4D05A004C for ; Fri, 25 Oct 2024 15:38:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729863528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AGtMo9b1TIIq8vmTJqt6ejA5lTIqLtTi/f9qo6vZAMU=; b=g4XmfC1xnZw5s62CC710M4NypEaVvJqNUXLTTVkLCgNMLVb0yklaB3EpjGdyVOvsxwmU9+ vRKKJI4zatdYUgDHBuWlwNzC2ulw/OUstZ38YYm8wr70dD3rL5Ds0M+H6JRqX23BsLdrI+ Zrk8PPmbspQuXIw9EpFeFGcOfe4ekr4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-G5rdJov1N-euhQ22Vsk2-w-1; Fri, 25 Oct 2024 09:38:46 -0400 X-MC-Unique: G5rdJov1N-euhQ22Vsk2-w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-431604a3b47so14670345e9.3 for ; Fri, 25 Oct 2024 06:38:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729863525; x=1730468325; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AGtMo9b1TIIq8vmTJqt6ejA5lTIqLtTi/f9qo6vZAMU=; b=pz3sOMVlUemjAgyKqB4r5ZwxTC48PRyI0uVasr7trLGDZxszuL8Rqn9HpzjVRJ4NHh +v4dRfHSGDhwoDaHKUxW6+ZtGw2cDAlCLsytMrdCbc4Cl3da2pr/sF5+MqaAKBWIopnk MVLBQU1NI0giHWtIW9T2Jicdd5hzN4mlB+KV/zVOUnNvN2JoJNx/YNWQwoy53pmn3Gre njpbDrd/sYWPuXO95cfiJwEas5TphoHFab9pTTKJhRMcxQWeEl5t6Wxexs6R8N2VKMTR 1jAb9mDtbo70F8WbzOwLCxjHf1x7LhjOi4UPb9jxvuGbCJKnYCplQqnkqfjmLRuacW5B 17Pw== X-Gm-Message-State: AOJu0YxCLboU2O3HzV1T2ovkL1V0eL4B0bUI/Bgu+p2unTDSUTRzfFp/ ZjoS4PHVas/+HJcV1FQQBDp/xWEXw5+8ytmGm5UVXoWd0tmEp4U/b+dnos92c7uzXTM7P+MhJiF 20rT3SzxzVt7cHd9y+q6cr/ae1PAUBu5EFZvGiMh7rnGKUGQL1wR01yaK8A== X-Received: by 2002:a05:600c:1987:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-4318c75d616mr48413205e9.30.1729863524886; Fri, 25 Oct 2024 06:38:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5EM55KpqCIraSUOo0B3aQ2+5SIb0AUcKEEDaFxho4lG7MfO6kox6mnuzWnK/qJ3/gkoyTRA== X-Received: by 2002:a05:600c:1987:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-4318c75d616mr48412965e9.30.1729863524438; Fri, 25 Oct 2024 06:38:44 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935a4c0esm18159575e9.27.2024.10.25.06.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 06:38:43 -0700 (PDT) Date: Fri, 25 Oct 2024 15:38:41 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/3] tcp: Runtime checks for availability of TCP_INFO fields Message-ID: <20241025153841.40e61a16@elisabeth> In-Reply-To: <20241024045922.3900584-1-david@gibson.dropbear.id.au> References: <20241024045922.3900584-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LJYBPKRSQX7BC6V6ZUVUI32J7NVSVILE X-Message-ID-Hash: LJYBPKRSQX7BC6V6ZUVUI32J7NVSVILE X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 24 Oct 2024 15:59:19 +1100 David Gibson wrote: > We have a number of Makefile tests for the presence of various fields > in tcp_info. However that only tells us if they're present in the > kernel headers against which we're compiling, not whether they're > available in the kernel we're running on. For anything outside the > earliest forms of TCP_INFO (as described in netinet/tcp.h and shared > with BSD), we should verify at runtime if the kernel is returning that > information. > > This was supposed to be leading into improved handling of lazily > calling TCP_INFO, but I hit additional complications there, so I've > postponed it. Might as well get these bits merged, though. > > v2: > * Previous version removed some #ifdefs that were still needed. > Simply putting them back leads to awkward duplication between the > "compile time missing" and "run time missing" cases, so take a > different approach which allows us to remove all of them. > * Some wording changes Applied with a trivial s/we here define/we define here/ and s/This taken/This is taken/ in 1/3. -- Stefano