From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zwh5U6hT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id A07995A004C for ; Fri, 25 Oct 2024 15:38:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729863533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiYyTMrAffFh7mD6AHOYOYdTtJiUXJMx7POt2/Zl/Fc=; b=Zwh5U6hTSVBaziSK1Izmmg5jXzAynEgpNqiyuNHI5uStelz9qKpU1C6ARDyAbqewFVKfOI oIH2hUcEVCiI1uwK6k7DyHXlzUvqnUMx5W+Hc5CGcvFHUEVTAkXyA+WxzpsATM/IjzdNtd x7O5kwAwKhFRJjnQTLwSOJ5rD8cVEYQ= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-62-Amv5CKdqMUKZJxUR8_yQxw-1; Fri, 25 Oct 2024 09:38:51 -0400 X-MC-Unique: Amv5CKdqMUKZJxUR8_yQxw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-7edae5ec254so656827a12.2 for ; Fri, 25 Oct 2024 06:38:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729863529; x=1730468329; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UiYyTMrAffFh7mD6AHOYOYdTtJiUXJMx7POt2/Zl/Fc=; b=i/JZlLaiAp9CUfno+pWquTYP7NR+hT/5IgohjAUVuo4R6L74+bCokFIbhN2NSZcG7g iJgclRxraGRXfAeVdlvzoAOt3Kox+RQsDIYznXXVtt/xfRXN+9tF5qpqltnuQLlYGR23 2/yomD7EVyiDlQwDSDXnKlUa1OTy3DFfIuSQTcnBhQ3iqcLVWdSMbwR/Lcpx7vfD7k1b fspnqlpuNKx2sNUBWcH60EoYlBId5EzSEXZpK7RNxFQkyWqWlRGZuWx9/bp0JdQG6F76 qq2muWCstyBnq37OcvCp//qynG7LwQYARy3UGCmpqJwlnJP0PPnxMsARMdvkOmswDZhl tBQA== X-Gm-Message-State: AOJu0YxsXwAKNMTxbVoOhEngIHR3WapLoG2YWFiyr89FZbP/stXCY5/9 vN7fGWmBvvap+DEUG7azKq3//Qj/gphvSwqxGNDIiRaKhhgRo+kEmorYlXGGN5ilW388gFXyPeF E1D335twL9ThkExWVYoJ7+y4e/SzYwoi5+LI+nHJkJJttrHZYjCe5/6z38P18w4d8eDr6hYBcjK A6GgJtAgFkaT75tfBw8fZpR/hY0ICDXUlD X-Received: by 2002:a17:903:22c9:b0:20c:b090:c87 with SMTP id d9443c01a7336-20fa9e5e485mr137602195ad.29.1729863529123; Fri, 25 Oct 2024 06:38:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjQrLgbCm1nY081AlWpAr6t1+zItbLBBZgjGVRX/cpjl1eKbH62s0Q4oTfTO8ElSkstB4mZw== X-Received: by 2002:a17:903:22c9:b0:20c:b090:c87 with SMTP id d9443c01a7336-20fa9e5e485mr137601875ad.29.1729863528707; Fri, 25 Oct 2024 06:38:48 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf6d6c7sm9490415ad.97.2024.10.25.06.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 06:38:48 -0700 (PDT) Date: Fri, 25 Oct 2024 15:38:45 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tcp: cleanup tcp_buf_data_from_sock() Message-ID: <20241025153845.59932e65@elisabeth> In-Reply-To: <20241024085058.348853-1-lvivier@redhat.com> References: <20241024085058.348853-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RFIB63YYAIVPXPPISPPD35WQSQR3RJ4K X-Message-ID-Hash: RFIB63YYAIVPXPPISPPD35WQSQR3RJ4K X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 24 Oct 2024 10:50:58 +0200 Laurent Vivier wrote: > Remove the err label as there is only one caller, and move code > to the caller position. ret is not needed here anymore as it is > always 0. > Remove sendlen as we can user directly len. > > Signed-off-by: Laurent Vivier Applied. -- Stefano