From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Mn2W2erD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 73C885A004C for ; Tue, 29 Oct 2024 14:57:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730210255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TQ6k+j+OVcDZ/63z1IsCJRl6P88Oi2eniQyXpI+2j+k=; b=Mn2W2erDC14jyWmrq9GEuY7Js0gJkkLfPDyQVN6HzvPbPvc4fms+2OPcuV3HGdOD6aRSsX WV7w6SGZsG3zrnFk4x3YJyLz94bN2MIjAJuPFLQAUN8ihlDhwTW7b4sn8P5vWULEiBsgwZ xNaSYbtfWZZLueBKGi1ycWH26pBuVDc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-4kMrstxUNJG9rXPQuzyNuA-1; Tue, 29 Oct 2024 09:57:34 -0400 X-MC-Unique: 4kMrstxUNJG9rXPQuzyNuA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d537292d7so3618985f8f.2 for ; Tue, 29 Oct 2024 06:57:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730210252; x=1730815052; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TQ6k+j+OVcDZ/63z1IsCJRl6P88Oi2eniQyXpI+2j+k=; b=CIOKLsSBC2/oLzwCDgXqsFXFqs1ieGdchYe9t92H9IIC+PKYuY0+o+oXcmQHg7mb47 QS/2MXqVpqSniJ0nfAfxOXuV12/ca/Dhqb2VYzig8mMbJTpqtSuxsJs2gsfi6y43J153 fFQC6xwiXSXlbskpSJme1EM+w/XXZ+8NVBCHoLjDhbWgryNwQlIrhjc87Hp0kpo7eot8 rni2RSLRYZso97KV/poV1TqPWr6gijuPmSoTFy47EkFEqSrsXTLNt/DJZD73OPA7/9mk IKZN1TeEGRa9l+Z7zoo4EFaXxs1NLH54J84PKS036a/pQYusMIGddgkglGt8mGhG26vN ymnQ== X-Gm-Message-State: AOJu0Yx+3zIs4Y3RdRKAPCjSx7x/i9uA6S2bhaGvTyq22oAZL74dgOvu GpZ+SPwNkgYy2gj7PrpvJ4b8Jlg6285yp3twm+snsUDjLbX0HLua74HuydqXqpDV6td2Buxg0QZ iw1RClgPQXeeqg//GXhRjcG262nG1LiYJWf87WRBF74fY4YZPb5auskOCIZLUpc9pkdRrhePuMr Au/emMpv2ArV7/msmZWnIiHElzuCYAsOBl X-Received: by 2002:a5d:61d2:0:b0:37c:cc4b:d1d6 with SMTP id ffacd0b85a97d-380611a495cmr11031107f8f.27.1730210251792; Tue, 29 Oct 2024 06:57:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkZsQpY5s9SLISRrdv8Hg9ZLUszlMCe8HBGrQ5DsclWlYEZygqHVoD5qO7FE4o3DCzIuCAFw== X-Received: by 2002:a5d:61d2:0:b0:37c:cc4b:d1d6 with SMTP id ffacd0b85a97d-380611a495cmr11031087f8f.27.1730210251371; Tue, 29 Oct 2024 06:57:31 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b3bc31sm12601907f8f.28.2024.10.29.06.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 06:57:30 -0700 (PDT) Date: Tue, 29 Oct 2024 14:57:29 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v5 0/2] tcp: unify IPv4 and IPv6 tap queues Message-ID: <20241029145729.32e45a7d@elisabeth> In-Reply-To: <20241029021400.784052-1-jmaloy@redhat.com> References: <20241029021400.784052-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KKHO7OHO3MXJKRHHFOH64HLQUJ246ZKA X-Message-ID-Hash: KKHO7OHO3MXJKRHHFOH64HLQUJ246ZKA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 28 Oct 2024 22:13:58 -0400 Jon Maloy wrote: > This should save us some memory and code. > > --- > v2: - Setting pointers to pre-set IP and MAC headers on the fly > instead of copying them. > - Merged patch #2 and #3 from v1 > v3: - Changes based on feedback from team > v4: - Rebased > v5: - Changes based on feedback from team and rebased > > Jon Maloy (2): > tcp: set ip and eth headers in l2 tap queues on the fly > tcp: unify l2 TCPv4 and TCPv6 queues and structures > > tcp.c | 6 +- > tcp_buf.c | 272 ++++++++++++++++++------------------------------------ > tcp_buf.h | 3 +- > 3 files changed, 91 insertions(+), 190 deletions(-) Applied. I also tested it with SO_PEEK_OFF support (kernel from current net.git HEAD), no issues observed. -- Stefano