public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v5 0/8] Take care of clang-tidy warnings with LLVM >= 16
Date: Wed, 30 Oct 2024 09:09:01 +0100	[thread overview]
Message-ID: <20241030080909.2781504-1-sbrivio@redhat.com> (raw)

So I started hitting some clang-tidy warnings with LLVM 16, some
looked bogus, so I upgraded to LLVM 19, and... I got even more. This
series takes care of them in different ways.

v5:
- ouch, it looks like I didn't test with 2/8 while rebasing this thing
  back and forth... replace snprintf() with vsnprintf() there,
  otherwise nothing works

v4:
- drop 5/9 and keep O_APPEND for the log file, turned off around log
  rotation, so that a hypothetical log file with multiple writers would
  still be somewhat consistent

v3:
- split 5/8 into 5/9 and 6/9: in the first, drop O_APPEND so that we can
  have a helper to open any output file we need, and in the second one,
  always use O_CLOEXEC for pcap file (and use the new helper, now that
  we can)

v2:
- make snprintf_check() return and set errno on failure, in 2/8
- add missing err_perror() calls on clock_gettime() failures in 6/8
- drop all explicit integer assignments in enum udp_iov_idx in 7/8

Stefano Brivio (8):
  Makefile: Exclude qrap.c from clang-tidy checks
  treewide: Comply with CERT C rule ERR33-C for snprintf()
  treewide: Silence cert-err33-c clang-tidy warnings for fprintf()
  Makefile: Disable readability-math-missing-parentheses clang-tidy
    check
  treewide: Suppress clang-tidy warning if we already use O_CLOEXEC
  treewide: Address cert-err33-c clang-tidy warnings for clock and timer
    functions
  udp: Take care of cert-int09-c clang-tidy warning for enum udp_iov_idx
  util: Don't use errno after a successful call in __daemon()

 Makefile | 13 +++++++---
 arch.c   |  6 ++++-
 conf.c   | 64 +++++++++++++++++++++++++++----------------------
 log.c    |  9 ++++---
 passt.c  |  9 ++++---
 pasta.c  | 11 ++++++---
 pcap.c   | 24 ++++++++++---------
 tap.c    |  5 ++--
 tcp.c    | 12 +++++++---
 udp.c    | 10 ++++----
 util.c   | 72 ++++++++++++++++++++++++++++++++++++--------------------
 util.h   |  7 +++++-
 12 files changed, 151 insertions(+), 91 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-10-30  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:09 Stefano Brivio [this message]
2024-10-30  8:09 ` [PATCH v5 1/8] Makefile: Exclude qrap.c from clang-tidy checks Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 2/8] treewide: Comply with CERT C rule ERR33-C for snprintf() Stefano Brivio
2024-10-30  8:45   ` David Gibson
2024-10-30  8:09 ` [PATCH v5 3/8] treewide: Silence cert-err33-c clang-tidy warnings for fprintf() Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 4/8] Makefile: Disable readability-math-missing-parentheses clang-tidy check Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 5/8] treewide: Suppress clang-tidy warning if we already use O_CLOEXEC Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 6/8] treewide: Address cert-err33-c clang-tidy warnings for clock and timer functions Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 7/8] udp: Take care of cert-int09-c clang-tidy warning for enum udp_iov_idx Stefano Brivio
2024-10-30  8:09 ` [PATCH v5 8/8] util: Don't use errno after a successful call in __daemon() Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030080909.2781504-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).