public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	omni <omni+alpine@hack.org>
Subject: [PATCH] tcp: Fix build against musl, __sum16 comes from linux/types.h
Date: Wed, 30 Oct 2024 21:50:10 +0100	[thread overview]
Message-ID: <20241030205010.325338-1-sbrivio@redhat.com> (raw)

...so we need to include that header explicitly. For some reason, it
works without it when building against glibc.

Reported-by: omni <omni+alpine@hack.org>
Fixes: 3d484aa37090 ("tcp: Update TCP checksum using an iovec array")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 tcp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tcp.c b/tcp.c
index 4e0a17e..429634a 100644
--- a/tcp.c
+++ b/tcp.c
@@ -287,6 +287,8 @@
 #include <time.h>
 #include <arpa/inet.h>
 
+#include <linux/types.h>	/* For __sum16 */
+
 #include "checksum.h"
 #include "util.h"
 #include "iov.h"
-- 
@@ -287,6 +287,8 @@
 #include <time.h>
 #include <arpa/inet.h>
 
+#include <linux/types.h>	/* For __sum16 */
+
 #include "checksum.h"
 #include "util.h"
 #include "iov.h"
-- 
2.43.0


             reply	other threads:[~2024-10-30 20:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 20:50 Stefano Brivio [this message]
2024-10-31  0:34 ` [PATCH] tcp: Fix build against musl, __sum16 comes from linux/types.h David Gibson
2024-10-31  6:56   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030205010.325338-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=omni+alpine@hack.org \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).