From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=Dk0S1S7K; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 312165A0625 for ; Wed, 06 Nov 2024 00:27:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1730849254; bh=gK64hJxRQEb975J4VpUy7gEkWQh1FDnmy1Hx6QdLapY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dk0S1S7KJWKcpDx5cUForFRV8hYuD6xDhUncK3v+TFOkF5Fvjub1bqZop5xtyqkmf 3rCKqEUTNJfVbqL/owggIPrpBxVXbnrkzcFJK6/DIlbNh4RUIKi8A66vOdAu0cjb2A HqbGfg5Lp00WIr+wn4zx59IOHht+w1/D4ycvrYQGkw+m3Zq1LcjOmOFXUr8Vpebk26 E4w+L+w9tqY4j9dgVpqG3MN8WmqduwI+DKczOh5aCpSF8Qw7aGgT5ILN0gA8HqxZcd j7Kt7r93BtJqEsMcGqqD8L1T3JK6cZbmbFqNpbIaIXmdAvYD5SvFjzFWdvqXa1/8mx N6IJN/kOxS/ng== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XjkyZ4cQsz4xHV; Wed, 6 Nov 2024 10:27:34 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 12/12] util: Remove unused ffsl() function Date: Wed, 6 Nov 2024 10:25:28 +1100 Message-ID: <20241105232528.1408144-13-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241105232528.1408144-1-david@gibson.dropbear.id.au> References: <20241105232528.1408144-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: IKF2I4B4P4FO2RLQTBMRNBFESJUJUEMM X-Message-ID-Hash: IKF2I4B4P4FO2RLQTBMRNBFESJUJUEMM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We supply a weak alias for ffsl() in case it's not defined in our libc. Except.. we don't have any users for it any more, so remove it. make cppcheck doesn't spot this at present for complicated reasons, but it might with tweaks to the options I'm experimenting with. Signed-off-by: David Gibson --- util.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/util.h b/util.h index c341236..2858b10 100644 --- a/util.h +++ b/util.h @@ -158,9 +158,6 @@ int do_clone(int (*fn)(void *), char *stack_area, size_t stack_size, int flags, struct ctx; -/* cppcheck-suppress funcArgNamesDifferent */ -__attribute__ ((weak)) int ffsl(long int i) { return __builtin_ffsl(i); } - #ifdef CLOSE_RANGE_UNSHARE /* Linux kernel >= 5.9 */ /* glibc < 2.34 and musl as of 1.2.5 need these */ #ifndef SYS_close_range -- 2.47.0