From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=kM+ueRji; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 14F485A061B for ; Wed, 06 Nov 2024 00:27:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1730849254; bh=85e/zY5aE9FTiE07gkiiEzRzzKS880gDhvtN0CPwSTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kM+ueRjiK94lEDgr8bMpCf9FD/J/atBWwd+U7LuZWB7PfRHDVXMxrctSmpx7XweMD J12QZK/s73u5FnmOr6xKYXthpPvzNyc4firR+YcCbTVtV3yypF3MUswPPeV/AcTmuF gMJU0x5pRI70qyunAwGbcT/6ISIe2Mw/DmzBnhyLEVFxA7ZkZgUXY+2YApAZnLvXzB O6iX0UvpL9fe+qmZVr0RSFQEBOCLKK27rL029H/bI/rXLsCKSdNhz+MTo/b8fbNGHr 4iBNXBGSZWr42ZQPfXwHjbeB0mYFnTu7QZaFDGtalTMUdw3NKXLEdYslOR1hZxvgt3 QJtjZa00kbzWg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XjkyZ47qYz4x9G; Wed, 6 Nov 2024 10:27:34 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 05/12] flow: Correct type of flowside_at_sidx() Date: Wed, 6 Nov 2024 10:25:21 +1100 Message-ID: <20241105232528.1408144-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241105232528.1408144-1-david@gibson.dropbear.id.au> References: <20241105232528.1408144-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZQTYT2SMUCL76BL2P4D3G3VZ6ICUXBC7 X-Message-ID-Hash: ZQTYT2SMUCL76BL2P4D3G3VZ6ICUXBC7 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Due to a copy-pasta error, this returns 'PIF_NONE' instead of NULL on the failure case. PIF_NONE expands to 0, which turns into NULL, but it's still confusing, so fix it. This removes a clang warning. Signed-off-by: David Gibson --- flow_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flow_table.h b/flow_table.h index a499e7b..f15db53 100644 --- a/flow_table.h +++ b/flow_table.h @@ -110,7 +110,7 @@ static inline const struct flowside *flowside_at_sidx(flow_sidx_t sidx) const union flow *flow = flow_at_sidx(sidx); if (!flow) - return PIF_NONE; + return NULL; return &flow->f.side[sidx.sidei]; } -- 2.47.0