From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=dBwgdjQ7; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 4F89E5A061B for ; Wed, 06 Nov 2024 02:44:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1730857455; bh=VMoxfoMwjLGw2MSsA6/sz4Xx52FphZNPVYOo6fTfuQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dBwgdjQ7GuATQ4U7CqbJjOEp6EanTIEKiYkmZPBxODGdRLMvsL4FkzfwFSOMQAP7o eTjlW+vBh9mLw96ejx+tPnduonmJgqLk9+cnHX3JKh4L0I8bUX2L5XNtM5LMk/t9RL MtLzdEnD9vVB8cwsP4EfGMrqCunKX+F+/vPEHJfy9dgOgQwgB5nXzwMQLpccq98KsQ MLb2Mth5UB+UPjHG552fexG/xJ5Y/dTsIit7c+WOq55p7tdweVvxSGCa3CmTbBKqCY o7e/2ALJKj6bzVbEQegMzCX0WEp34rsQfjHqewp1ZFm8qmgVPoGbMzEWyEVl1r4GM/ P9NTx8wYzy7bQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Xjp0H0JM6z4xCV; Wed, 6 Nov 2024 12:44:15 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/2] test: Don't require 64-bit prefixes in perf tests Date: Wed, 6 Nov 2024 12:44:14 +1100 Message-ID: <20241106014415.1765896-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241106014415.1765896-1-david@gibson.dropbear.id.au> References: <20241106014415.1765896-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: BEQQZ4SOYIN7G24OLWCKSSBWP7VA7FOK X-Message-ID-Hash: BEQQZ4SOYIN7G24OLWCKSSBWP7VA7FOK X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When determining the namespace's IPv6 address in the perf test setup, we explicitly filter for addresses with a 64-bit prefix length. There's no real reason we need that - as long as it's a global address we can use it. I suspect this was copied without thinking from a similar example in the NDP tests, where the 64-bit prefix length _is_ meaningful (though it's not entirely clear if the handling is correct there either). Signed-off-by: David Gibson --- test/perf/pasta_tcp | 2 +- test/perf/pasta_udp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp index d1ccf7d..88284b2 100644 --- a/test/perf/pasta_tcp +++ b/test/perf/pasta_tcp @@ -211,7 +211,7 @@ tr TCP throughput over IPv6: host to ns iperf3s ns 10002 nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type == "ether").ifname' -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global" and .prefixlen == 64).local' +nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global").local' bw - bw - bw - diff --git a/test/perf/pasta_udp b/test/perf/pasta_udp index 544bf17..3d07091 100644 --- a/test/perf/pasta_udp +++ b/test/perf/pasta_udp @@ -196,7 +196,7 @@ tr UDP throughput over IPv6: host to ns iperf3s ns 10002 nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type == "ether").ifname' -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global" and .prefixlen == 64).local' +nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global").local' iperf3 BW host __ADDR6__ 10002 __TIME__ __OPTS__ -b 8G -l 1472 bw __BW__ 0.3 0.5 iperf3 BW host __ADDR6__ 10002 __TIME__ __OPTS__ -b 12G -l 3972 -- 2.47.0