Re: [PATCH v2 1/1] iov: iov tail helpers

[Stefano Brivio <sbrivio@redhat.com>]

On Fri,  8 Nov 2024 15:19:30 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> In the vhost-user code we have a number of places where we need to locate
> a particular header within the guest-supplied IO vector.  We need to work
> out which buffer the header is in, and verify that it's contiguous and
> aligned as we need.  At the moment this is open-coded, but introduce a
> helper to make this more straightforward.
> 
> We add a new datatype 'struct iov_tail' representing an IO vector from
> which we've logically consumed some number of headers.  The IOV_PULL_HEADER
> macro consumes a new header from the vector, returning a pointer and
> updating the iov_tail.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  iov.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  iov.h | 76 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 169 insertions(+)

This looks good to me now. Should I apply this, or wait until it's
actually used?

-- 
Stefano