From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A7nekTFJ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E728C5A0621 for ; Fri, 08 Nov 2024 11:38:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731062280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3KIS96bvHG3xcZFXEAZyduxjPXNAa0wGA7weCtD7snc=; b=A7nekTFJ97dUvZkHrXjs/rYvR3VHvNlVT+FNOahqGxyIYgZZcxp4Ci9oM7U8KzpCa9C7SV qCyWsofSq+7qKB+WXZS0hfO/67aRUyvSyPY6/r8s6lVGlLCNBr6w+5qyLXZPsy4lTno0LI AAGbkXJlY7FRL8SdNIY8PA1vlLGRdTI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-Uk3u6r5rNJ2Wl9mYUrOu0g-1; Fri, 08 Nov 2024 05:37:58 -0500 X-MC-Unique: Uk3u6r5rNJ2Wl9mYUrOu0g-1 X-Mimecast-MFC-AGG-ID: Uk3u6r5rNJ2Wl9mYUrOu0g Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 85C991955F2B; Fri, 8 Nov 2024 10:37:57 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.39.194.73]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 352AD1953882; Fri, 8 Nov 2024 10:37:55 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH v10 12/12] tcp: Adjust iov_len before filling headers Date: Fri, 8 Nov 2024 11:37:31 +0100 Message-ID: <20241108103733.3554357-13-lvivier@redhat.com> In-Reply-To: <20241108103733.3554357-1-lvivier@redhat.com> References: <20241108103733.3554357-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uxpUzww-6g3Yohi4XJ6ilU_2ZDHSvjsDqFfqVlMfpmg_1731062277 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: 73HNV6QW5QIR3DG25UGE36SOWUYWMNDC X-Message-ID-Hash: 73HNV6QW5QIR3DG25UGE36SOWUYWMNDC X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: David Gibson Currently tcp_fill_headers[46] return the size of the IP payload, which we use to adjust the size of the last IOV entry for the frame, so that it only includes the expected data. This was originally done to isolate knowledge of the header layout to the header building functions. However, we've since reorganised things so that the callers have knowledge of the layout anyway. Use that knowledge to adjust iov_len *before* we call tcp_fill_headers*(). This means that the header building functions are called with the IOV containing the frame and only the frame, which will be useful later on. For the vhost-user flags, this also simplifies things a bit, since we'd actually already separately calculated the header length. For the vhost-user data case, we'd already shortened the final IOV from tcp_vu_data_from_sock(). Signed-off-by: David Gibson Signed-off-by: Laurent Vivier --- tcp.c | 24 ++++++++---------------- tcp_buf.c | 36 +++++++++++++++++------------------- tcp_internal.h | 17 +++++++++-------- tcp_vu.c | 22 +++++++++------------- 4 files changed, 43 insertions(+), 56 deletions(-) diff --git a/tcp.c b/tcp.c index 63870aa5e454..85d783d403a2 100644 --- a/tcp.c +++ b/tcp.c @@ -977,13 +977,11 @@ static void tcp_fill_header(struct tcphdr *th, * @check: Checksum, if already known * @seq: Sequence number for this segment * @no_tcp_csum: Do not set TCP checksum - * - * Return: The IPv4 payload length, host order */ -size_t tcp_fill_headers4(const struct tcp_tap_conn *conn, - struct tap_hdr *taph, struct iphdr *iph, - struct tcp_payload_t *bp, size_t dlen, - const uint16_t *check, uint32_t seq, bool no_tcp_csum) +void tcp_fill_headers4(const struct tcp_tap_conn *conn, + struct tap_hdr *taph, struct iphdr *iph, + struct tcp_payload_t *bp, size_t dlen, + const uint16_t *check, uint32_t seq, bool no_tcp_csum) { const struct flowside *tapside = TAPFLOW(conn); const struct in_addr *src4 = inany_v4(&tapside->oaddr); @@ -1014,8 +1012,6 @@ size_t tcp_fill_headers4(const struct tcp_tap_conn *conn, } tap_hdr_update(taph, l3len + sizeof(struct ethhdr)); - - return l4len; } /** @@ -1028,13 +1024,11 @@ size_t tcp_fill_headers4(const struct tcp_tap_conn *conn, * @check: Checksum, if already known * @seq: Sequence number for this segment * @no_tcp_csum: Do not set TCP checksum - * - * Return: The IPv6 payload length, host order */ -size_t tcp_fill_headers6(const struct tcp_tap_conn *conn, - struct tap_hdr *taph, struct ipv6hdr *ip6h, - struct tcp_payload_t *bp, size_t dlen, - uint32_t seq, bool no_tcp_csum) +void tcp_fill_headers6(const struct tcp_tap_conn *conn, + struct tap_hdr *taph, struct ipv6hdr *ip6h, + struct tcp_payload_t *bp, size_t dlen, + uint32_t seq, bool no_tcp_csum) { const struct flowside *tapside = TAPFLOW(conn); size_t l4len = dlen + sizeof(bp->th); @@ -1065,8 +1059,6 @@ size_t tcp_fill_headers6(const struct tcp_tap_conn *conn, } tap_hdr_update(taph, l4len + sizeof(*ip6h) + sizeof(struct ethhdr)); - - return l4len; } /** diff --git a/tcp_buf.c b/tcp_buf.c index 6f8f5bb5cc21..52a19eda850c 100644 --- a/tcp_buf.c +++ b/tcp_buf.c @@ -194,28 +194,26 @@ void tcp_payload_flush(const struct ctx *c) * @check: Checksum, if already known * @seq: Sequence number for this segment * @no_tcp_csum: Do not set TCP checksum - * - * Return: IP payload length, host order */ -static size_t tcp_l2_buf_fill_headers(const struct tcp_tap_conn *conn, - struct iovec *iov, size_t dlen, - const uint16_t *check, uint32_t seq, - bool no_tcp_csum) +static void tcp_l2_buf_fill_headers(const struct tcp_tap_conn *conn, + struct iovec *iov, size_t dlen, + const uint16_t *check, uint32_t seq, + bool no_tcp_csum) { const struct flowside *tapside = TAPFLOW(conn); const struct in_addr *a4 = inany_v4(&tapside->oaddr); if (a4) { - return tcp_fill_headers4(conn, iov[TCP_IOV_TAP].iov_base, - iov[TCP_IOV_IP].iov_base, - iov[TCP_IOV_PAYLOAD].iov_base, dlen, - check, seq, no_tcp_csum); + tcp_fill_headers4(conn, iov[TCP_IOV_TAP].iov_base, + iov[TCP_IOV_IP].iov_base, + iov[TCP_IOV_PAYLOAD].iov_base, dlen, + check, seq, no_tcp_csum); + } else { + tcp_fill_headers6(conn, iov[TCP_IOV_TAP].iov_base, + iov[TCP_IOV_IP].iov_base, + iov[TCP_IOV_PAYLOAD].iov_base, dlen, + seq, no_tcp_csum); } - - return tcp_fill_headers6(conn, iov[TCP_IOV_TAP].iov_base, - iov[TCP_IOV_IP].iov_base, - iov[TCP_IOV_PAYLOAD].iov_base, dlen, - seq, no_tcp_csum); } /** @@ -252,8 +250,9 @@ int tcp_buf_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags) return ret; tcp_flags_used++; - l4len = tcp_l2_buf_fill_headers(conn, iov, optlen, NULL, seq, false); + l4len = optlen + sizeof(struct tcphdr); iov[TCP_IOV_PAYLOAD].iov_len = l4len; + tcp_l2_buf_fill_headers(conn, iov, optlen, NULL, seq, false); if (flags & DUP_ACK) { struct iovec *dup_iov; @@ -287,7 +286,6 @@ static void tcp_data_to_tap(const struct ctx *c, struct tcp_tap_conn *conn, { const uint16_t *check = NULL; struct iovec *iov; - size_t l4len; conn->seq_to_tap = seq + dlen; tcp_frame_conns[tcp_payload_used] = conn; @@ -305,8 +303,8 @@ static void tcp_data_to_tap(const struct ctx *c, struct tcp_tap_conn *conn, iov[TCP_IOV_IP] = IOV_OF_LVALUE(tcp6_payload_ip[tcp_payload_used]); iov[TCP_IOV_ETH].iov_base = &tcp6_eth_src; } - l4len = tcp_l2_buf_fill_headers(conn, iov, dlen, check, seq, false); - iov[TCP_IOV_PAYLOAD].iov_len = l4len; + iov[TCP_IOV_PAYLOAD].iov_len = dlen + sizeof(struct tcphdr); + tcp_l2_buf_fill_headers(conn, iov, dlen, check, seq, false); if (++tcp_payload_used > TCP_FRAMES_MEM - 1) tcp_payload_flush(c); } diff --git a/tcp_internal.h b/tcp_internal.h index 21e31a03a83d..2989db7fb224 100644 --- a/tcp_internal.h +++ b/tcp_internal.h @@ -183,14 +183,15 @@ void tcp_update_check_tcp4(const struct iphdr *iph, void tcp_update_check_tcp6(const struct ipv6hdr *ip6h, const struct iovec *iov, int iov_cnt, size_t l4offset); -size_t tcp_fill_headers4(const struct tcp_tap_conn *conn, - struct tap_hdr *taph, struct iphdr *iph, - struct tcp_payload_t *bp, size_t dlen, - const uint16_t *check, uint32_t seq, bool no_tcp_csum); -size_t tcp_fill_headers6(const struct tcp_tap_conn *conn, - struct tap_hdr *taph, struct ipv6hdr *ip6h, - struct tcp_payload_t *bp, size_t dlen, - uint32_t seq, bool no_tcp_csum); +void tcp_fill_headers4(const struct tcp_tap_conn *conn, + struct tap_hdr *taph, struct iphdr *iph, + struct tcp_payload_t *bp, size_t dlen, + const uint16_t *check, uint32_t seq, bool no_tcp_csum); +void tcp_fill_headers6(const struct tcp_tap_conn *conn, + struct tap_hdr *taph, struct ipv6hdr *ip6h, + struct tcp_payload_t *bp, size_t dlen, + uint32_t seq, bool no_tcp_csum); + int tcp_update_seqack_wnd(const struct ctx *c, struct tcp_tap_conn *conn, bool force_seq, struct tcp_info_linux *tinfo); int tcp_prepare_flags(const struct ctx *c, struct tcp_tap_conn *conn, diff --git a/tcp_vu.c b/tcp_vu.c index 260dda7887e1..4df7186d0006 100644 --- a/tcp_vu.c +++ b/tcp_vu.c @@ -95,7 +95,7 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags) struct vu_dev *vdev = c->vdev; struct vu_virtq *vq = &vdev->vq[VHOST_USER_RX_QUEUE]; const struct flowside *tapside = TAPFLOW(conn); - size_t l2len, l4len, optlen, hdrlen; + size_t optlen, hdrlen; struct vu_virtq_element flags_elem[2]; struct tcp_flags_t *tcp_flags; struct ipv6hdr *ip6h = NULL; @@ -150,22 +150,18 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags) return ret; } + flags_elem[0].in_sg[0].iov_len = hdrlen + optlen; + if (CONN_V4(conn)) { - l4len = tcp_fill_headers4(conn, NULL, iph, - (struct tcp_payload_t *)tcp_flags, optlen, - NULL, seq, true); - l2len = sizeof(*iph); + tcp_fill_headers4(conn, NULL, iph, + (struct tcp_payload_t *)tcp_flags, optlen, + NULL, seq, true); } else { - l4len = tcp_fill_headers6(conn, NULL, ip6h, - (struct tcp_payload_t *)tcp_flags, - optlen, seq, true); - l2len = sizeof(*ip6h); + tcp_fill_headers6(conn, NULL, ip6h, + (struct tcp_payload_t *)tcp_flags, + optlen, seq, true); } - l2len += l4len + sizeof(struct ethhdr); - - flags_elem[0].in_sg[0].iov_len = l2len + - sizeof(struct virtio_net_hdr_mrg_rxbuf); if (*c->pcap) { tcp_vu_update_check(tapside, &flags_elem[0].in_sg[0], 1); pcap_iov(&flags_elem[0].in_sg[0], 1, -- 2.47.0