From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QrgW2zBX; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 576785A004C for ; Fri, 08 Nov 2024 12:27:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731065255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1hKNK0SLEkcqhIvAi0yZ9QnS0Q29eNVIMzvKEM3kyM=; b=QrgW2zBXIfil1GcM7+C855uRyrMxK2Zugr6qI+sN0Pb7H9IJzTf4V995BuemkV3LBIwDew D5b7CGuVmFJXql5d7DysC4TOf2/k0/JvSQKB1mHbp6RnbqDLiEivoEOBgJBQNu9tjTb53o GTM+VzID1t6tK2dcGxJoOTLlJzT/ObE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-Y4pFApUCNaePjxrgRlA8ww-1; Fri, 08 Nov 2024 06:27:33 -0500 X-MC-Unique: Y4pFApUCNaePjxrgRlA8ww-1 X-Mimecast-MFC-AGG-ID: Y4pFApUCNaePjxrgRlA8ww Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d662dd3c8so1195267f8f.1 for ; Fri, 08 Nov 2024 03:27:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731065251; x=1731670051; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l1hKNK0SLEkcqhIvAi0yZ9QnS0Q29eNVIMzvKEM3kyM=; b=eUYIKvpDWPZ7GBOPyRnVdp80Ud2fHuknxMccZOqWyWv+/JA0952l0KtdN5B+Bo8drk bMT0BooN5U4zeMRIRCFkalvVj3tDmh8r0CoIh4tHxr53Zx/4Kr0zBEv7ydk9xtsrys40 x2yddlO58nek/VC3YyVR0Bf+G0gxlMkVz/aCPRz2fRg5jnsbNDyPbtFtIAB/EGrmy6xz uT9LKfm5EXxicRDccvUXrojMqzMhpaz6WYXmnDgsbByWgUh3Eu+hQ+vkyLkfaHPuEm3g B5LKNHK0EQqqMh7/t8pITJgrVjoR1VpnR9QB0xToAse4/M/5001R7n7edJTKbtyjLkRC 5ggQ== X-Gm-Message-State: AOJu0Yzryu/R3GqjotC3b+UnRbbE+jZN9oMniO6KXKXb81Ug4jYeaH0G /Fux5igFosYvJznOPPD7IbwQ4kv46zp0QuKCqRTOrwyX6Rgt19douVOPwWwVud4qlppFZVkBfUT hTIDYhc4QhrXGHjP8I0v92TE7Sy59sc9xJiYM/aLphm7y19xTSR/GFpfAhucI7He8620lz+Tnzh KWTqBmiWr54MOADF5teFaH5w/1EClVmH3V X-Received: by 2002:a05:6000:2183:b0:37d:3735:8fe7 with SMTP id ffacd0b85a97d-381f1834de4mr1393467f8f.32.1731065251267; Fri, 08 Nov 2024 03:27:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEX5VT4muA5ickwNS/N9ElTiIlWGogVeTZ2fj+YLQFzu9w7Zag7t1VgBb53+fosFiSrtEanrg== X-Received: by 2002:a05:6000:2183:b0:37d:3735:8fe7 with SMTP id ffacd0b85a97d-381f1834de4mr1393454f8f.32.1731065250840; Fri, 08 Nov 2024 03:27:30 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed97cfefsm4297007f8f.26.2024.11.08.03.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 03:27:29 -0800 (PST) Date: Fri, 8 Nov 2024 12:27:28 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v10 00/12] Add vhost-user support to passt. (part 3) Message-ID: <20241108122728.2c8aad3d@elisabeth> In-Reply-To: <20241108103733.3554357-1-lvivier@redhat.com> References: <20241108103733.3554357-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FNfraOZC363fbUPNHt75yG-gnfrufhf1p7Z101KR-Jg_1731065253 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NGGSBZPNOSRWQRE44RQHP3O5QN25ULGA X-Message-ID-Hash: NGGSBZPNOSRWQRE44RQHP3O5QN25ULGA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 8 Nov 2024 11:37:19 +0100 Laurent Vivier wrote: > v10: > - rebase v9 on top of my changes > - remove last 4 patches from v9 as > 'tcp: Pass TCP header and payload separately to tcp_fill_headers[46]()' > introduces a regression in "make check" for me. > - addressed comments from David > - I tried to cleanup iov management, but I was not able to remove the > update of the first iov to point to the header or to the data > - upd_vu_hdrlen()/tcp_vu_hdrlen() includes now the size of the > virtio-net header > - I didn't address comments from Stefano. > - I didn't fix the bug with seek_offset_cap ...is there anything in particular you need reviewed on this revision? -- Stefano