public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/6] ndp: Unsolicited RAs
Date: Tue, 12 Nov 2024 15:06:12 +1100	[thread overview]
Message-ID: <20241112040618.1804081-1-david@gibson.dropbear.id.au> (raw)

The default route a guest obtains via NDP has an expiry.  We set this
to the maximum allowed, 65535s (about 18 hours).  We missed, however,
that after that expiry, the guest won't send a new Router
Solicitation.  Instead it expects an unsolicited Router Advertisement
to have come at some point before the expiry.  This means that on an
IPv6 setup, the default will disappear after 18 hours.

Correct this by sending unsolicited Router Advertisements as required
by RFC 4861.  Along the way we make a number of small cleanups to the
NDP code.

Link: https://github.com/kubevirt/kubevirt/issues/13191

David Gibson (6):
  ndp: Remove redundant update to addr_seen
  ndp: Add ndp_send() helper
  ndp: Split out helpers for sending specific NDP message types
  ndp: Use struct assignment in preference to memcpy() for IPv6
    addresses
  ndp: Make route lifetime a #define
  ndp: Send unsolicited Router Advertisements

 ip.h    |   9 +++
 ndp.c   | 210 ++++++++++++++++++++++++++++++++++++--------------------
 ndp.h   |   7 +-
 passt.c |   3 +
 4 files changed, 152 insertions(+), 77 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-11-12  4:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12  4:06 David Gibson [this message]
2024-11-12  4:06 ` [PATCH 1/6] ndp: Remove redundant update to addr_seen David Gibson
2024-11-12  4:06 ` [PATCH 2/6] ndp: Add ndp_send() helper David Gibson
2024-11-12  4:06 ` [PATCH 3/6] ndp: Split out helpers for sending specific NDP message types David Gibson
2024-11-13  1:14   ` Stefano Brivio
2024-11-13  2:07     ` David Gibson
2024-11-12  4:06 ` [PATCH 4/6] ndp: Use struct assignment in preference to memcpy() for IPv6 addresses David Gibson
2024-11-12  4:06 ` [PATCH 5/6] ndp: Make route lifetime a #define David Gibson
2024-11-12  4:06 ` [PATCH 6/6] ndp: Send unsolicited Router Advertisements David Gibson
2024-11-13  1:14   ` Stefano Brivio
2024-11-13  3:01     ` David Gibson
2024-11-13  8:18       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112040618.1804081-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).